> * The _insert_lines and _update_line method in *_base_completion/statement.py should call the symbol_f method to prorperly initiate the default value (e.g. integer default null value should be Null not False).
Definitely
> * The mechanism that allow to have a null account_id in bank statement line should be part of *_base_completion, not *_base_import.
+1, but IMO we need to provide a completion rule that mimics the current behavior so the user keeps a way to fill the account_id with the same logic as the one provided by account_bank_statement_ext by using this completion rule. To avoid unexpected behavior after the module's upgrade, we probably need to provide a migration script adding this completion rule on existing profiles
> * The _insert_lines and _update_line method in *_base_ completion/ statement. py should call the symbol_f method to prorperly initiate the default value (e.g. integer default null value should be Null not False).
Definitely
> * The mechanism that allow to have a null account_id in bank statement line should be part of *_base_completion, not *_base_import.
+1, but IMO we need to provide a completion rule that mimics the current behavior so the user keeps a way to fill the account_id with the same logic as the one provided by account_ bank_statement_ ext by using this completion rule. To avoid unexpected behavior after the module's upgrade, we probably need to provide a migration script adding this completion rule on existing profiles