The code for matching st. lines to move lines is not expandable and difficult to maintain

Bug #1020688 reported by Carlos Vásquez (ClearCorp) on 2012-07-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Banking Addons
Wishlist
Unassigned

Bug Description

Hi,

We are starting to use the banking-addons modules to implement better banking capabilities in OpenERP for Costa RIca.

We need to expand the functionality in order to accomplish our objective. We are very happy to see that the code is well documented. But the way that the match method and it's dependent methods are implemented doesn't allow us to localize the banking-addons without having to rewrite several methods completely.

Before we do this and duplicate the work between the teams, I would like to know if you are open to a code refactor, only in form. We can reorganize the code doing more small methods, without changing it's current functionality. That way we can inherit the objects and change only some of those methods, or even inherit them (with a super call).

We need to invest time in this either way, but we rather do it in the right way getting these addons better.

I will wait for your feedback while we start designing the changes and start localizing some parts of it.

Hi Carlos,

a lot of voices in the OpenERP community have recently expressed that the Banking Addons fulfil a certain need, but do so in a heavyweight, monolithic manner. For a start, the Banking Addons should be split up into separate modules for

- basic functionality (i.e. importing bank statements)
- integration with account_payment for exporting payment and direct debit orders
- automatic matching according to customizable or localized rules
- interactive matching
- account number validation and lookup

Your initiative fits perfectly within this goal. A merge proposal will be more than welcome.

Cheers,
Stefan.

OK. Glad to hear this. We will be working on this and hopefully we will
have improvements to share with everyone.

We will keep in mind what you propose as module distribution for the
project.

Thank you,
--
PS: escribí este email desde mi teléfono, por favor disculpe la brevedad y
cualquier error de escritura.

Carlos Vásquez
CTO · Director de Ingeniería
CLEARCORP S.A.

<email address hidden>
CR: +(506) 4000-CORP (4000-2677)
US: +1 (786) 472-4267
Cel: +(506) 8351-4484
skype: crvasquez
twitter: cvclearcorp

300 m. Este de la Escuela
Calle de Platanares
11402 San Jerónimo, Moravia
San José, Costa Rica

http://www.clearcorp.co.cr

Download full text (3.7 KiB)

Hello guys,

We had the same concern a Akretion. And recently CampToCamp had needs
around similar features but ended creating a few simpler modules instead of
using the banking addons.
Ideally this has been discussed with Stefan and we will hopefully see a
convergence between the banking-addons modularization and the base work
done by CampToCamp. The work by CampToCamp is yet to be a bit more
documented. But at least, just in case and to make sure you don't redevelop
something twice, here is where their modules are located:
http://bazaar.launchpad.net/~c2c/c2c-financial-addons/6.1/files

As a remark, Joel had to copy/paste in a ugly way some bank statement
methods because OpenERP base methods wouldn't be modular enough, he will
try to get some merges in the 7.0 release so their modules become cleaner.
And we community should rush to help those core refactoring to been made
before 7 is frozen forever without the support we need.

On our side, we made restart our work based on C2C addons and then
eventually see if we go as far as the banking addons.

Thank you for you collaboration.

--
Raphaël Valyi
Founder and consultant
http://twitter.com/rvalyi <http://twitter.com/#!/rvalyi>
+55 21 2516 2954
www.akretion.com

On Wed, Jul 4, 2012 at 10:40 AM, Carlos Vásquez (CLEARCORP) <
<email address hidden>> wrote:

> OK. Glad to hear this. We will be working on this and hopefully we will
> have improvements to share with everyone.
>
> We will keep in mind what you propose as module distribution for the
> project.
>
> Thank you,
> --
> PS: escribí este email desde mi teléfono, por favor disculpe la brevedad y
> cualquier error de escritura.
>
> Carlos Vásquez
> CTO · Director de Ingeniería
> CLEARCORP S.A.
>
> <email address hidden>
> CR: +(506) 4000-CORP (4000-2677)
> US: +1 (786) 472-4267
> Cel: +(506) 8351-4484
> skype: crvasquez
> twitter: cvclearcorp
>
> 300 m. Este de la Escuela
> Calle de Platanares
> 11402 San Jerónimo, Moravia
> San José, Costa Rica
>
> http://www.clearcorp.co.cr
>
> --
> You received this bug notification because you are a member of Banking
> Addons Team, which is the registrant for Banking Addons.
> https://bugs.launchpad.net/bugs/1020688
>
> Title:
> The code for matching st. lines to move lines is not expandable and
> difficult to maintain
>
> Status in Banking Addons:
> New
>
> Bug description:
> Hi,
>
> We are starting to use the banking-addons modules to implement better
> banking capabilities in OpenERP for Costa RIca.
>
> We need to expand the functionality in order to accomplish our
> objective. We are very happy to see that the code is well documented.
> But the way that the match method and it's dependent methods are
> implemented doesn't allow us to localize the banking-addons without
> having to rewrite several methods completely.
>
> Before we do this and duplicate the work between the teams, I would
> like to know if you are open to a code refactor, only in form. We can
> reorganize the code doing more small methods, without changing it's
> current functionality. That way we can inherit the objects and change
> only some of those methods, or even inherit them (wi...

Read more...

Raphaël,

Thank you, noted.

We know the financial reports module of the c2c branch. We will test the
banking modules and see where to go from there.

I will get back as soon as we have something to report.
--
PS: escribí este email desde mi teléfono, por favor disculpe la brevedad y
cualquier error de escritura.

Carlos Vásquez
CTO · Director de Ingeniería
CLEARCORP S.A.

<email address hidden>
CR: +(506) 4000-CORP (4000-2677)
US: +1 (786) 472-4267
Cel: +(506) 8351-4484
skype: crvasquez
twitter: cvclearcorp

300 m. Este de la Escuela
Calle de Platanares
11402 San Jerónimo, Moravia
San José, Costa Rica

http://www.clearcorp.co.cr

Hi Carlos,

if you are still working on breaking up the matching code, can you indicate what the status is? We need to prepare for the upgrade to 7.0 and if you have something near completion now would be a good time to take it into consideration.

Cheers,
Stefan.

Hi Stephan,

We have been very busy this year with several projects, so we had to put
the clean up on hold. We are using 6.1-ccorp branch inside the project as
production code. It has several changes we need in Costa Rica, but it is
more like a temporary work-around.

We have 2 bank statement import modules relying on that branch, so we will
more than happy to help as much as we can to have a better banking-addons
for 7.0.

Regards,
--
PS: escribí este email desde mi teléfono, por favor disculpe la brevedad y
cualquier error de escritura.

Carlos Vásquez
CTO · Director de Ingeniería
CLEARCORP S.A.

<email address hidden>
CR: +(506) 4000-CORP (4000-2677)
US: +1 (786) 472-4267
Cel: +(506) 8351-4484
skype: crvasquez
twitter: cvclearcorp

300 m. Este de la Escuela
Calle de Platanares
11402 San Jerónimo, Moravia
San José, Costa Rica

http://www.clearcorp.co.cr

Hi Carlos,

that is clear. Thanks for the update!

Regards,
Stefan.

Changed in banking-addons:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers