The patch looks good, I'll just ask for Jason for a second look, I think we can remove other parts like:
- matcher = bamf_matcher_get_default ();
- control = bamf_control_get_default ();
- source = g_object_new (BAMF_TYPE_TAB_SOURCE, "id", "testingsource", NULL);
+ bamf_matcher_get_default ();
+ bamf_control_get_default ();
+ g_object_new (BAMF_TYPE_TAB_SOURCE, "id", "testingsource", NULL);
-> if we don't reference them, there is no need at all for those calls or objects ;)
Hey Adam, thanks for your patch :)
The patch looks good, I'll just ask for Jason for a second look, I think we can remove other parts like: get_default (); get_default (); TAB_SOURCE, "id", "testingsource", NULL); get_default (); get_default (); TAB_SOURCE, "id", "testingsource", NULL);
- matcher = bamf_matcher_
- control = bamf_control_
- source = g_object_new (BAMF_TYPE_
+ bamf_matcher_
+ bamf_control_
+ g_object_new (BAMF_TYPE_
-> if we don't reference them, there is no need at all for those calls or objects ;)
Jason?