Comment 3 for bug 706703

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Adam, thanks for your patch :)

The patch looks good, I'll just ask for Jason for a second look, I think we can remove other parts like:
- matcher = bamf_matcher_get_default ();
- control = bamf_control_get_default ();
- source = g_object_new (BAMF_TYPE_TAB_SOURCE, "id", "testingsource", NULL);
+ bamf_matcher_get_default ();
+ bamf_control_get_default ();
+ g_object_new (BAMF_TYPE_TAB_SOURCE, "id", "testingsource", NULL);

-> if we don't reference them, there is no need at all for those calls or objects ;)

Jason?