Comment 86 for bug 32963

Paul,

Here's the output from the source packages:

conn@dimension:~/work$ grep -r XV_CONTRAST vlc-0.8.6.release/
vlc-0.8.6.release/modules/video_output/x11/xvideo.c: * XV_CONTRAST.
"f_value" should be in the range of 0 to 1.
vlc-0.8.6.release/modules/video_output/x11/xcommon.c: XVideoSetAttribute(
p_vout, "XV_CONTRAST", 0.5 );

conn@dimension:~/work$ grep -r XV_CONTRAST totem-2.18.0/

conn@dimension:~/work$ grep -r XV_CONTRAST xserver-xorg-video-i810-1.7.4/
xserver-xorg-video-i810-1.7.4/src/xvmc/I810XvMC.c: pI810XvMC->xv_contrast =
XInternAtom(display,"XV_CONTRAST",0);
xserver-xorg-video-i810-1.7.4/src/xvmc/I810XvMC.c: {XvGettable |
XvSettable, 0, 0x1ff, "XV_CONTRAST"},
xserver-xorg-video-i810-1.7.4/src/xvmc/I810XvMC.c:// XV_CONTRAST
xserver-xorg-video-i810-1.7.4/src/xvmc/I810XvMC.c:// XV_CONTRAST
xserver-xorg-video-i810-1.7.4/src/xvmc/I810XvMC.c:// XV_CONTRAST
xserver-xorg-video-i810-1.7.4/src/i810_video.c: {XvSettable | XvGettable,
0, 255, "XV_CONTRAST"}
xserver-xorg-video-i810-1.7.4/src/i810_video.c: xvContrast =
MAKE_ATOM("XV_CONTRAST");
xserver-xorg-video-i810-1.7.4/src/i830_video.c: {XvSettable | XvGettable,
0, 255, "XV_CONTRAST"},
xserver-xorg-video-i810-1.7.4/src/i830_video.c: {XvSettable | XvGettable,
0, 255, "XV_CONTRAST"},
xserver-xorg-video-i810-1.7.4/src/i830_video.c: xvContrast =
MAKE_ATOM("XV_CONTRAST");

Strangely, totem doesn't refer to XV_CONTRAST at all. But...

conn@dimension:~/work$ grep -r CONTRAST totem-2.18.0/
totem-2.18.0/po/rw.po:# sw/source\ui\utlui\attrdesc.src:STR_CONTRAST.text
totem-2.18.0/src/backend/bacon-video-widget-gst-0.10.c: else if
(type == BVW_VIDEO_CONTRAST && channel &&
totem-2.18.0/src/backend/bacon-video-widget-gst-0.10.c:
g_strrstr (channel->label, "CONTRAST"))
totem-2.18.0/src/backend/bacon-video-widget-gst-0.10.c: else if
(type == BVW_VIDEO_CONTRAST && channel &&
totem-2.18.0/src/backend/bacon-video-widget-gst-0.10.c:
g_strrstr (channel->label, "CONTRAST"))
totem-2.18.0/src/backend/bacon-video-widget-xine.c:
XINE_PARAM_VO_CONTRAST,
totem-2.18.0/src/backend/bacon-video-widget.h: BVW_VIDEO_CONTRAST,
totem-2.18.0/src/totem-preferences.c: BVW_VIDEO_CONTRAST,
(int) i);
totem-2.18.0/src/totem-preferences.c: BVW_VIDEO_CONTRAST);

There's a few possibilities we can look into: a) totem-preferences.c, or b)
changing the i810 driver's contrast handling.

On 3/22/07, Paul Sladen <email address hidden> wrote:
>
> Excellent summary Conn. Thanks for that. Could you 'apt-get source'
> both the packages for totem and for a known-working program (vlc?), then
> locate the appropriate place/file in each so that we can compare the
> broken code to the good.
>
> Doing a:
>
> grep -r XV_CONTRAST
>
> in the source tree maybe enough to find the place where it is
> set/queried.
>
> ** Changed in: xserver-xorg-video-i810 (Ubuntu)
> Status: Fix Released => Rejected
>
> ** Changed in: xorg (Ubuntu)
> Sourcepackagename: xorg => totem
> Status: Rejected => Confirmed
>
> --
> Xv movies on 810/i945 gives horrible color, Gamma
> https://launchpad.net/bugs/32963
>