Baltix
gnome-system-tools package

  1. Bug #236305
  2. Comment #15

Comment 15 for bug 236305

Revision history for this message
Martin Pitt (pitti) wrote :

Also marking for hardy. This sounds like a good SRU. However, I'm not happy with the patch yet:

 - It introduces new strings, which needs to be avoided for i18n reasons.
 - Hardcoding "admin" sounds wrong to me. Shouldn't it rather just check whether the user/group already exists? The current code does

   } else if (!user && login_exists (login)) {

  So what about changing login_exists() to also check for the group with the same name? That would solve the issue more generically and avoid string changes.