Spread - Clicking on a app icon to spread the windows must always show all the windows, regardless of whether or not some of the windows are minimised

Reported by John Lea on 2011-04-04
32
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Critical
John Lea
Unity
High
Didier Roche
unity-2d
Undecided
Unassigned
unity (Ubuntu)
Undecided
Unassigned

Bug Description

Currently if you trigger a spread by clicking on a app icon in the Launcher, only windows that are not minimized are displayed!

Desired behaviour:

All spreads should always show all windows, irrespective of whether the windows are minimised or not.

Clicking on a app icon to spread the windows must always show all the windows, regardless of whether or not some of the windows are minimised

John Lea (johnlea) on 2011-04-04
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
status: New → Fix Released
importance: Undecided → Critical
Changed in unity:
status: New → Triaged
assignee: nobody → Neil J. Patel (njpatel)
milestone: none → 3.8.4
tags: added: udt
Changed in unity-2d:
status: New → Fix Released
Didier Roche (didrocks) on 2011-04-05
Changed in unity (Ubuntu):
status: New → Triaged
Neil J. Patel (njpatel) on 2011-04-07
Changed in unity:
assignee: Neil J. Patel (njpatel) → Didier Roche (didrocks)

Just a braindump here. There are two ways this can be done. The first
is to never actually unmap windows when iconified - instead to shape
out their input. This is supported in compiz already in the
workarounds plugin but the code uses some interesting hacks which
might cause problems. The second solution is to unminimize all windows
first and then initiate scale. There could be some performance issues
that cone out of this one though since unminimizing windows is quite
heavy X-wise

Sent from my iPod

On Apr 7, 2011, at 17:08, "Neil J. Patel" <email address hidden>
wrote:

> ** Changed in: unity
> Assignee: Neil J. Patel (njpatel) => Didier Roche (didrocks)
>
> --
> You received this bug notification because you are a member of Unity
> Bugs, which is subscribed to unity.
> https://bugs.launchpad.net/bugs/750349
>
> Title:
> Spread - Clicking on a app icon to spread the windows must always
> show
> all the windows, regardless of whether or not some of the windows are
> minimised
>
> Status in Ayatana Design:
> Fix Released
> Status in Unity:
> Triaged
> Status in Unity 2D:
> Fix Released
> Status in “unity” package in Ubuntu:
> Triaged
>
> Bug description:
> Currently if you trigger a spread by clicking on a app icon in the
> Launcher, only windows that are not minimized are displayed!
>
> Desired behaviour:
>
> All spreads should always show all windows, irrespective of whether
> the windows are minimised or not.
>
>
> Clicking on a app icon to spread the windows must always show all the
> windows, regardless of whether or not some of the windows are
> minimised

Didier Roche (didrocks) wrote :

Fixed with unminimized, see FIXME in the code:

just unminimize minimized window for selected apps for now, don't minimize them after the scale if not picked as TerminateScale is only called if you click on the launcher, not on any icon. More generally, we should hook up InitiateScale and TerminateScale to a Scale plugin signal as the shortcut will have a different behaviour then.

Changed in unity:
status: Triaged → Fix Committed
importance: Undecided → High
Didier Roche (didrocks) on 2011-04-07
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package unity - 3.8.4-0ubuntu1

---------------
unity (3.8.4-0ubuntu1) natty; urgency=low

  * New upstream release.
    - [fglrx] compiz crashed with SIGSEGV in nux::IOpenGLSurface::UnlockRect()
      (LP: #685682)
    - SIGSEGV in g_atomic_int_get (LP: #688803)
    - unity-panel-service crashed with SIGSEGV in bamf_factory_view_for_path()
      (LP: #717684)
    - New window tracking system breaks in the case where windows try to
      restack relative to destroyed windows that were never mapped
      (LP: #723014)
    - Numpad 'Enter' doesn't work on highlighted items in dash, places-files and
      places-apps (LP: #741615)
    - compiz crashed with SIGSEGV in free() (LP: #738864)
    - compiz crashed with SIGSEGV in g_closure_invoke() (LP: #741674)
    - compiz crashed with SIGSEGV in CompWindow::id() (LP: #742028)
    - Windows that reparent away from the root before they are mapped can
      cause other windows to become invisible (and compiz to crash)
      (LP: #743011)
    - compiz crashed with SIGABRT in raise() (LP: #743414)
    - compiz crashed with SIGSEGV in g_object_get_qdata() (LP: #742905)
    - compiz crashed with SIGSEGV in g_closure_invoke() (LP: #748033)
    - compiz crashed with SIGSEGV in CompScreen::dpy() (LP: #751372)
    - compiz crashed with SIGABRT in __kernel_vsyscall() (LP: #744867)
    - unity-window-decorator crashed with SIGSEGV in gdk_window_get_events()
      (LP: #725284)
    - Missing icons in app launcher (LP: #728393)
    - Multiple quick clicks on launcher icon with multiple windows completely
      crashes Unity (LP: #731790)
    - Add a test case for invisible windows regressions (LP: #736876)
    - Re-sync with xquerytree to avoid stacking order issues (LP: #740465)
    - Wrong window moves (LP: #741656)
    - compiz crashed with SIGSEGV in g_cclosure_marshal_VOID__VOID()
      (LP: #742280)
    - panel superposition (LP: #742859)
    - unity-window-decorator doesn't start on secondary X session
      (LP: #730495)
    - Unity Launcher stops autohiding and is not responsive (LP: #744325)
    - dash categories dropdown menu leaves "ghost" on desktop (LP: #746800)
    - new dialogs open close enough of the launcher to make hide (LP: #747302)
    - dnd from the application place to the launcher works only once
      (LP: #747316)
    - compiz crashed with SIGSEGV in CompWindow::id() while opening tcl/tk
      interface of R (LP: #747439)
    - minimize animates window fading to the top left corner (ubuntu symbol)
      (LP: #747765)
    - Spread - Clicking on a app icon to spread the windows must always show
      all the windows, regardless of whether or not some of the windows are
      minimised (LP: #750349)
    - Launcher - Show visual de-coupling of Launcher app icons (LP: #751196)
    - unity-window-decorator crashed with SIGSEGV in event_filter_func()
      (LP: #748317)
    - Pressing Super-W to switch windows also presents Dash (LP: #753453)
    - Don't create windows over the launcher (LP: #688816)
    - Unity Grid is broken for multi-monitor setups (LP: #709221)
    - F10 key does not move focus to indicators when on the desktop.
      (LP: #727548)
    - dynamic ...

Read more...

Changed in unity (Ubuntu):
status: Triaged → Fix Released

That's a really bad fix. That's just a workaround.

Picking up one minimised window without unminimise everything else is not possible for example.

I think that's a regression, and that's inconsistent with Unity 2d.

Cameron Hart (bitshifternz) wrote :

I've created a patch which minimizes windows again after then spread is dismissed. This should address Fabien's issue with the fix for #750349.

https://code.launchpad.net/~bitshifternz/unity/bug-750349-restore-state

It's worth noting though that a focus (clicking another active application's launcher icon) will also unminimize minimized windows for that application. That behaviour is a separate issue unrelated to the fix for 750349 and my patch listed here.

John Lea (johnlea) on 2011-04-18
tags: added: reviewedbydesign
removed: udt
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers