Comment 6 for bug 278388

Revision history for this message
Michael Rooney (mrooney) wrote :

Thanks for taking the initiative Kevin! I have talked about improving this before and I think that your patch addresses half the issue. Since the HTML code itself could change, it is possible that the same issue could happen with this approach. Also, I think page requests to get the URL every time are unnecessary bandwidth for users and could slow things down. I think the optimal way to address this issue is to ship the applet with the current known address as we do, but instead as an awnconfig key (whatever the proper name is for that, that goes to gconf in gnome). Then, wrap the fetching of the flash in a try, and if it can't be found, THEN try your new approach. If successful, put that new value in gconf and continue. This way, you only need to fetch the URL once per change, and even if they completely change HTML, we can at least tell users the new value to put in gconf as a relatively simple fix.