Comment 1 for bug 1083435

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote : Re: Eventuallyr() should have a variable time delay

Hi Jeff,

This sounds like a do-able feature addition. Thinking about it from an API point of view, would you be happy with this?

self.assertThat(foo.something, Eventually(Equals(24), timeout=20)

... to make Eventually wait 20 seconds. Leaving the keywork property out:

self.assertThat(foo.something, Eventually(Equals(24))

would default to 10 seconds.

AssertProperty is harder to fix - since there's no easy way to differentiate between a 'timeout' keyword, and a test against an attribute called 'timeout'.

Another option is to have some call like:

self.setAssertionTimeout(20)

which would set the timeout value to 20 seconds for the current test only. It's less fine-grained, but would work for both assertions.

I'm keen to get your feedback on this.

Cheers,