batch/make/version is broken

Bug #314784 reported by dlh on 2009-01-07
4
Affects Status Importance Assigned to Milestone
Armagetron Advanced
Status tracked in Trunk
Trunk
High
Yann Kaiser

Bug Description

$ batch/make/version .
armagetronad-0.3.1_alpha_z 0

This is not a valid version.

dlh (dlh) on 2009-01-07
Changed in armagetronad:
importance: Undecided → High
milestone: none → 0.3.1
Manuel Moos (z-man) wrote :

Details? What's the source of your source tree? It works for me for svn checkouts, bzr checkouts and branches. It probably doesn't work for uncompressed tarballs, but it isn't called then.

Changed in armagetronad:
status: New → Incomplete
dlh (dlh) wrote :
Dave Fancella (davefancella) wrote :

I have reverted the file again. As far as I know, it works fine for 0.3.1 and is only needed to generate reasonable version numbers for builds from the repository. So it should be fixed in the trunk. Can we quit merging in the bad trunk version, or at least revert this particular file? ;)

Dave Fancella (davefancella) wrote :

This needs to be targeted for the trunk.

Changed in armagetronad:
assignee: nobody → epsy
milestone: 0.3.1 → none
status: Incomplete → Confirmed
Manuel Moos (z-man) wrote :

Sorry ;) The bad version was only restored because
1. the "good" version produces errors on output
2. the squashing wasn't marked as intentional, but appeared to be an unwanted side effect of a different commit
3. the "bad" version is working just fine for me.

dlh (dlh) wrote :

The problems are because of gnu-specific sed expressions being used. I worked on the script a little, but there are still some branches that I didn't touch that had sed expressions in them. Such as the "elif test ${missing} -eq 0" branch, and the "if test $versioned" branch.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers