Powered aircraft types explode permanently on their crash if powering structure is lost

Bug #1075936 reported by Rodrigo Gonzales
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ares
Fix Released
Medium
AlexB

Bug Description

If an aircraft type is powered by a structure, and that structure is lost while the aircraft type is flying, the aircraft will crash, as expected. However while falling, it will trail numerous "explosion" animations until crashing into the ground.

Revision history for this message
AlexB (alexander-b) wrote :

Is that by using the PoweredBy logic or the PoweredUnit logic?

Changed in ares:
status: New → Incomplete
status: Incomplete → Triaged
status: Triaged → Incomplete
Revision history for this message
Rodrigo Gonzales (mustafa-khalil) wrote :

Issue cropped up with PoweredBy=.

Revision history for this message
Rodrigo Gonzales (mustafa-khalil) wrote :

Seems like it gets re-destroyed on every tic of the game as it still checks as existing during its fall, hence exploding again and again.

Revision history for this message
mevitar (mevitar) wrote :

I can confirm this issue. AircraftTypes with PoweredBy= explode each frame (at least it looks like each frame) while falling when they become unpowered.

Changed in ares:
status: Incomplete → Confirmed
AlexB (alexander-b)
Changed in ares:
milestone: none → 0.2p2
status: Confirmed → Fix Committed
importance: Undecided → Medium
assignee: nobody → AlexB (alexander-b)
Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

In what branch is this fix committed? I could not see this fixed in d03 and fat man.

Revision history for this message
AlexB (alexander-b) wrote :

I changed the PoweredBy logic in Fatman to not destroy a unit if it has been destroyed already. I didn't test it, thus I can't actually say whether this is working at all. If this problem is still happening since Fatman 12.337.974, the fix doesn't work.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

When used the latest fat man, from unstable builds, the result was exactly the same as the older version(ie, the things described by the OP and mevitar).

Revision history for this message
FS-21 (jagarni1983) wrote :

After testing 12.337.974 I confirm that it doesn't fix the explosions problem.

Revision history for this message
AlexB (alexander-b) wrote :

I uploaded a new v02 binary, 12.339.1154, which will hopefully fix this.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

Yepp, that fixed it.

Revision history for this message
FS-21 (jagarni1983) wrote :

Yes, 12.339.1154 fixed it.

Revision history for this message
AlexB (alexander-b) wrote :

Cool. Thanks, guys!

Changed in ares:
status: Fix Committed → Fix Released
Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

Do you need more verifications before you can start work on 0.3 again?

Revision history for this message
AlexB (alexander-b) wrote :

What do you want to verify? All current issues have been closed as of the post above yours.

Revision history for this message
YR M0ddEr (yr-m0dder) wrote :

I was referring to other issues that might need extra testing, not this one.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.