Metabug: Ares warhead effects does not check if projectile hit the target at all

[Graion Dilach]

Thereby Ares warhead effects always hit the target even if the projectile itself missed/detonated elsewhere.

[Rodrigo Gonzales (mustafa-khalil)]

I suspect I brought this up by pointing out the issue with Ripple effect. Didn't expect that I'd unearth something of this size with it.

[mevitar (mevitar)]

No, it was spotted with at least one other Ares feature earlier, but then nobody realized that something else might be the cause.

[Graion Dilach (graiondilach)]

As far as I know (and I knew these stuff pretty well back on the old tracker) any bugs related to this one never got reported until recently.

I don't deny the fact that this is a real bug... it's just none cared about enough much to create a report about it IMO.

[mevitar (mevitar)]

Actually, people might forgot about it. Just yesterday i realized that i saw that ripple bug myself some time ago, but then i wanted to be sure that it wasn't the projectile's fault. Later i changed the weapon to something else, and completely forgot about the bug, so Rodrigo reported something that i should have done so long time ago.

Still, this made me think... What if bug#911940 is also part of this (and i recently saw that bug happen to bombs with AE)? EMP working on aircrafts despite the weapon hitting the ground (this bug was reported, but i can't find it) might be caused by this, LS not accepting EMP, Ares effects not working on animations might also be caused by this issue (because YR tags, like Psychedelic=yes and Rocker=yes WORK on animations that deal damage), etc, all those might be caused by this one.

[Graion Dilach (graiondilach)]

LS and AnimWarheads are separated things, in their case, relevant hooks does not call the Ares warhead functions, while this bug is about that said function considers the hit granted.

911940 do sounds like a part of this tho, if the effect gets stacked 5 times on the intended target.

[mevitar (mevitar)]

Something i found about PreImpactAnim.

Like other Ares stuff, it doesn't check whether the projectile hit the target. It always hits in the spot that it was targeted at, not where the projectile actually hit. Try with a bombing run airstrike SW, it will be clearly visible. It will also cause the warhead to detonate at the spot PreImpactAnim appeared, not where the projectile hit (tested with a bombing run SW that spawns fire particles - they all spawned at the same spot, while without PreImpactAnim, they spawned at the spots where the bombs hit).

However, if Damage value on the weapon is set to 0, the PreImpactAnim will this time appear exactly where the projectile hits, like it should. Other Ares tags are unaffected, they will always affect targets around the targeted cell.

[mevitar (mevitar)]

I think this should be added to 0.9 feature list, and can be marked as fixed, as AE, Ripple, etc. now appear at the spot the warhead detonates, not where the target is.

[AlexB (alexander-b)]

Also confirmed here: http://www.ppmsite.com/forum/viewtopic.php?p=523342#523342