Comment 7 for bug 1201454

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

Hi Julian,

OK, I looked at that, and yes some odd values that seem to oscillate, and then go negative. I have a simple "fix" that should work. I'd appreciate it if you can test it. In terminatorlib.window.py find the following

    def set_rough_geometry_hints(self):
        """Walk all the terminals along the top and left edges to fake up how
        many columns/rows we sort of have"""
        if not hasattr(self, 'cached_maker'):
            self.cached_maker = Factory()

and change it to:

    def set_rough_geometry_hints(self):
        """Walk all the terminals along the top and left edges to fake up how
        many columns/rows we sort of have"""
        if self.ismaximised == True:
            return
        if not hasattr(self, 'cached_maker'):
            self.cached_maker = Factory()

This should keep the normal unmaximised behaviour of a stepped resize, while preventing the odd behaviour on Fluxbox and Windows/XMing when maximising.. If it works for you, I'll commit the fix.