I'm OK with adding UPnP_MiniUPnPc to dcpp (although I don't particularly like the class name). However, I'm with Razzloss that I would like to see a HAVE_MINIUPNPC or HAVE_UPNP compile time flag be added. I can add it myself once it's committed, but I wouldn't know how to integrate it with the windows build system. We're concerned with adding another library dependency for a feature that is not widely used, unless there is a way to make it optional. The flag is a bit of a hack, but without some sort of plug-in system to allow for dynamic loading of libraries at run-time it is the best option we have.
I'm OK with adding UPnP_MiniUPnPc to dcpp (although I don't particularly like the class name). However, I'm with Razzloss that I would like to see a HAVE_MINIUPNPC or HAVE_UPNP compile time flag be added. I can add it myself once it's committed, but I wouldn't know how to integrate it with the windows build system. We're concerned with adding another library dependency for a feature that is not widely used, unless there is a way to make it optional. The flag is a bit of a hack, but without some sort of plug-in system to allow for dynamic loading of libraries at run-time it is the best option we have.