Comment 19 for bug 230973

Revision history for this message
Razzloss (razzloss) wrote :

The horrible code I was talking about was the miniupnp library itself. Not the COM implementation (though I guess COM interface is quite ugly, haven't looked at it, just simply because it's COM.).

I mentioned dynamic linking because we prefer to keep our external dependencies external so those will be updated with the normal OS updating mechanisms without the need for linuxdcpp rebuild. And from that comes the need for the miniupnp related things be easily enabled/disabled with compile time options, as some distributions don't include the library.

--RZ