Comment 16 for bug 230973

Revision history for this message
Razzloss (razzloss) wrote :

Depends on what you mean by in the core. As a feature UPnP support in the core is preferable over GUI implementation, but for linux the library shouldn't be statically linked. So if it's added so that the support can be disabled at compile time and we can use the miniupnp library provided with (some) distros, then I have no objections (if you think the code is good enough. Last time I evaluated it, maybe a year ago, it looked pretty horrible. Though I guess it's a bit better now.).

--RZ