Comment 22 for bug 1280522

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/121582
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5dd34c93e2c86fdba7b71e27029a400777bf9424
Submitter: Jenkins
Branch: master

commit 5dd34c93e2c86fdba7b71e27029a400777bf9424
Author: Sean Dague <email address hidden>
Date: Mon Sep 15 10:00:36 2014 -0400

    fix up assertEqual(None...) check to catch more cases

    To finally close out bug #1280522 it turned out that our hacking check
    to eliminate assertEqual(None, ...) was pretty sub optimal. The
    perfect fix would actually use the tokenizer, however this is a better
    regex which catches a few more missing bits in our codebase. It's
    probably close enough for most of what we need.

    Fix the relevant tests that would fail the updating hacking check.

    Change-Id: Ic8cb1192e001409d827c8da55fe536681895944b
    Closes-Bug: #1280522