Rev 543 disconnects PING user

Bug #880488 reported by Pirre on 2011-10-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ADCH++
Low
Unassigned

Bug Description

It seems that that last access modification lets a user with SUP pass 2 times the verification status, and disconnects him with reason 1 , think thats CID change :) the momet it verify's the CID second time

poy (poy) wrote :

probably fixed in rev 544.

Changed in adchpp:
status: New → Invalid
Pirre (pierreparys) wrote :

now the pinger stay's in IDENTIFY state untill the timeout disconnects him, have tryed to see what happens using the pinger in debug mode but there you can only see parts of what he receives , not what he sends

Changed in adchpp:
status: Invalid → In Progress
Pirre (pierreparys) wrote :

Have tryed this with 7 different clients , none has a prob with sending that INF after the users verification, seems its only the pinger that not replys on the ISID, have posted a support ticket on dchublist.

Access.lua does seems completely correct now.

IF the protocol not specifies that the IINF must be send first, then the pinger is wrong.

Just a warning using this rev 544 will cause the hub the disappear from the hublist .... , will post answer from hublist here :)

Pirre (pierreparys) wrote :

No answer, commited a tmp fix in rev 558

Changed in adchpp:
importance: Undecided → Low
status: In Progress → Fix Committed
Pirre (pierreparys) wrote :

Untill DCHubhlist updates pinger .....

Changed in adchpp:
status: Fix Committed → Triaged
Derek Gal (dchublist.org) wrote :

This was fixed at dchublist.org today.
No ip patch needed as of Sept.09.2018
Pinger now sends BINF - wchich was missing prev.

poy (poy) wrote :

workaround which sent the hub's INF earlier (before full user login) removed in the next ADCH++ version.
the workaround was limited to an old (now unused) IP anyways.

for reference, that workaround could not be generalized as it could result in information being sent about private hubs without having to log in.

Changed in adchpp:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers