Comment 33 for bug 23369

Revision history for this message
In , Yinbolian (yinbolian) wrote :

>actually, it looks like you can share the pref list between your
>prefNameMapping (which should have been gPrefNameMapping) and your sysPrefList
>maps - why not just have one big map, instead of two maps that you have to keep
>in sync?

Hi Alecf, Thanks for your comments.

I think I should explain the reasons why there are two pref list. "sysPrefList"
and "prefNameMapping" are used for different purposes, they are not needed to be
in sync, and their sizes maybe differ greatly. So they should not be combined
into one.

"prefNameMapping" is the name mapping between Mozila prefs and host system prefs
(i.e. gconf on gnome). I hope to list as many items as possible in
"prefNameMapping". In other systems there may be a very different mapping list.

"sysPrefList" tells mozilla what prefs should be read from system if they are
available in the current version.

For all other things in the comments, I will change in the next revision of the
patch.

-Bolian