Comment 15 for bug 1836754

Revision history for this message
melanie witt (melwitt) wrote :

I lean toward the more aggressive approach for most if not all delete requests because IMHO a delete request from a user should never be rejected.

I updated Matt's WIP patch to address the existing comments about a month ago when I noticed this failure popping up on the consumer types set:

https://review.opendev.org/c/openstack/nova/+/688802/2

Based on the discussion on the review, in most cases in ^ it was appropriate to "force" a delete, with the exception being during reclaim of SOFT_DELETED instances if an operator has configured deferred deletes. Based on this, it seems like our prior state of DELETE /allocations was more appropriate than what we have currently since the vast majority of the time we should be DELETEing for our purposes.

An alternative approach brought up on the WIP patch review [1] was to just revert:

https://review.opendev.org/c/openstack/nova/+/591597

I'm going to upload a revert of ^ as an option and see what the consensus is among everyone on which way to go.

[1] https://review.opendev.org/c/openstack/nova/+/688802/2#message-8be9a96ce27a2bf1f1118bce6cc387096210ffda