Comment 10 for bug 1780775

Revision history for this message
Ian Bruce (ian-bruce) wrote :

further discussion of these issues may be found here:

https://gitlab.com/inkscape/inkscape/merge_requests/303

The node-handle-locking and info-text bugs have been fixed. However, it appears that the undo/redo node-type-change bug probably will not be addressed, for reasons that remain unclear.

If anyone cares to look into it, it's easy to reproduce, using the "node-bug.svg" test case, attached above. This description is copied from the GitLab discussion:

- enter node-edit mode, and select the cusp node at the top of the red quadrilateral. hover the mouse over it, and observe that the info box at the bottom of the window confirms that it is a "cusp node".

- convert the node to smooth, using either the GUI tool or the keyboard shortcut. again, hover the mouse over the node, and observe that the info box now describes it as a "smooth node".

- "undo" this operation. hover the mouse over the node, and observe that it is once again described as a "cusp node".

- "redo" the node-change operation. hover the mouse over the node, and observe that although the positions of the control handles have been "redone", it is STILL identified as a "cusp node".

- move one of the control handles, and observe that the other DOES NOT maintain collinearity with it. which is, of course, the definition of a "cusp node".

Conclusion: undo/redo DOES NOT WORK in the context of node-type changes.