Comment 15 for bug 174720

Revision history for this message
bbyak (buliabyak) wrote : Re: [Bug 174720] Re: currentColor in style= is misinterpreted

On Tue, Apr 8, 2008 at 7:42 AM, Martin von Gagern
<email address hidden> wrote:
> The culprit is sp_style_write_ipaint, which writes the color value even if the color is set to currentColor. The attached patch solves that; it should be used in addition to the one above.

thanks, committed

> I haven't really investigated how color profiles should interact with
> all this. I would assume that sp_style_merge_ipaint should copy the
> color profile information as well as the color value, but that doesn't
> happen so far, and might cause further bugs similar to this one here.
> Any comments on this?

forwarding to Jon Cruz who's implemented the profiles stuff

> bbyak: I'll patch anything I encounter myself and find the time to fix,
> but I don't have the time so far to fix issues that don't affect me
> myself, and I like a second opinion before the fix gets applied, so I
> don't think I'll need commit permissions any time soon.

OK, thanks, your contributions are welcome in any case :)