Comment 11 for bug 174720

Revision history for this message
Martin von Gagern (gagern) wrote :

I did some more debugging in order to find out where the currentcolor flag got cleared. This happens at the beginning of sp_style_read. One would assume that the flag should be restored from the style specification string, but this is not the case. A look at the value of the style attribute tells you why:
repr->attribute("style"): "color:#00ffff;fill:currentColor #00ffff;stroke:currentColor #00ffff"
The culprit is sp_style_write_ipaint, which writes the color value even if the color is set to currentColor. The attached patch solves that; it should be used in addition to the one above.

I haven't really investigated how color profiles should interact with all this. I would assume that sp_style_merge_ipaint should copy the color profile information as well as the color value, but that doesn't happen so far, and might cause further bugs similar to this one here. Any comments on this?

bbyak: I'll patch anything I encounter myself and find the time to fix, but I don't have the time so far to fix issues that don't affect me myself, and I like a second opinion before the fix gets applied, so I don't think I'll need commit permissions any time soon.