Comment 1 for bug 1208013

Revision history for this message
Tomasz Boczkowski (penginsbacon) wrote :

Summary of failing test:

CurveTest::testGetSegmentCount
  fixed by attached path. One of test segments was commented out during merge. The patch fixes that.

CurveTest::testNodesInPath
  fixed by attached path. According to comment in line 93 zero lenght closing segments should not increase the node count.

CurveTest::testLastFirstSegment
  I'm not sure if the test is correct. Should closing an empty path add a segment to it?

CurveTest::testLastPoint
  When path is closed, last point is != first point. I'll post a patch fixing Geom::Path behaviour.

CurveTest::testPenultimatePoint
   SPCurve::penultimate_point() is dead code. It is not used since revision 8855. I think this test and penultimate_point method can be deleted.