x2gokdrive 0.0.0.2-1build1 FTBFS

[Nick Rosbrook]

x2gokdrive 0.0.0.2-1build1 is stuck in -proposed. It FTBFS on all arches with:

mkdir -p '/<<PKGBUILDDIR>>/BUILD/xorg-server/hw/kdrive/x2gokdrive/'
# inject x2gokdrive into xorg-server build tree
cp 'Makefile.am' *'.c' *'.h' '/<<PKGBUILDDIR>>/BUILD/xorg-server/hw/kdrive/x2gokdrive/'
cp -r '/<<PKGBUILDDIR>>/man/' 'BUILD/xorg-server/hw/kdrive/x2gokdrive/'
# patch xorg-server build tree, so that it will build x2gokdrive
set -x; \
 export XORG_UPSTREAM_VERSION="$(grep AC_INIT '/<<PKGBUILDDIR>>/BUILD/xorg-server/configure.ac' | sed -r 's/^AC_INIT[^,]*, ([^,]+),.*/\1/')" && \
 cd '/<<PKGBUILDDIR>>/BUILD/xorg-server' && \
 if [ -d "../../patches.xorg/${XORG_UPSTREAM_VERSION}" ]; then \
  QUILT_PATCHES="../../patches.xorg/${XORG_UPSTREAM_VERSION}/" quilt pop -a; \
  rm .pc/ -Rfv; \
  QUILT_PATCHES="../../patches.xorg/${XORG_UPSTREAM_VERSION}/" quilt push -a; \
 else \
  ( \
   set +x; \
   printf '\n##################################################\nERROR: This X2Go KDrive version does not support\nbuilding against X.Org version %s.\n##################################################\n' "${XORG_UPSTREAM_VERSION}"; \
   exit '1'; \
  ); \
 fi
+ grep AC_INIT /<<PKGBUILDDIR>>/BUILD/xorg-server/configure.ac
+ sed -r s/^AC_INIT[^,]*, ([^,]+),.*/\1/
+ export XORG_UPSTREAM_VERSION=21.1.11
+ cd /<<PKGBUILDDIR>>/BUILD/xorg-server
+ [ -d ../../patches.xorg/21.1.11 ]
+ set +x

##################################################
ERROR: This X2Go KDrive version does not support
building against X.Org version 21.1.11.
##################################################
make[1]: *** [debian/rules:26: override_dh_auto_configure] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:15: binary-arch] Error 2
dpkg-buildpackage: error: debian/rules binary-arch subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-03-26T01:00:11Z

Even the latest version in sid (0.0.0.3-1 at time of writing) does not have patches.xorg/21.1.11.

[Nick Rosbrook (enr0n)]

Ah, but the latest debian version does relax this requirement, so we could just cherry pick that fix. I will try that.

[Nick Rosbrook (enr0n)]

Using the new debian/rules is sufficient to resolve the build, so I cherry-picked those changes from Debian and uploaded.

[Launchpad Janitor (janitor)]

This bug was fixed in the package x2gokdrive - 0.0.0.2-1ubuntu1

---------------
x2gokdrive (0.0.0.2-1ubuntu1) noble; urgency=medium

  * Fix FTBFS agaist newer X.org versions (LP: #2059132). Fixes cherry-picked
    from Debian:
    - debian/rules: Work-around for broken upstream tarball. Place latest-
      available symlink into patches.xorg/.
    - debian/rules: Tolerate newer X.org versions when building.

 -- Nick Rosbrook <email address hidden> Tue, 26 Mar 2024 10:54:36 -0400