zfs should enable autotrim

[Dimitri John Ledkov]

[Impact]

 * Ubuntu enables automatic TRIM / DISCARD on all filesystems that support it, such that on SSD-like storage devices the performance over time is improved. ZFS, as setup by ubiquity, did not used to enable autotrim option. But it should have it enabled.

[Test Case]

 1. Complete install using zfs
 2. Reboot and login
 3. Check that the zfs pools have autotrim feature enabled with the following command:
# zpool get autotrim

Both pools must have the autotrim property set to 'on'.
NAME PROPERTY VALUE SOURCE
bpool autotrim on local
rpool autotrim on local

You can also check the status of trimming with:
# zpool status -t rpool
  pool: rpool
 state: ONLINE
  scan: none requested
config:

        NAME STATE READ WRITE CKSUM
        rpool ONLINE 0 0 0
          nvme0n1p4 ONLINE 0 0 0 (100% trimmed, completed at mer. 03 juin 2020 07:50:22)

[Regression Potential]

 * When autotrim is in progress, i/o performance may be observed as stalling. However, periodic trim outweighs the benefits. Advanced operators may choose to disable autotrim, and execute it manually during regularly scheduled maintenance windows.

[Other Info]

 * Shipped in groovy already

[Brian Murray (brian-murray)]

Hello Dimitri, or anyone else affected,

Accepted ubiquity into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/20.04.15.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

> * Check that the zfs pools have autotrim feature enabled

Please be explicit about how this is checked.

[Jean-Baptiste Lallement (jibel)]

SRU verification for Focal:
I have reproduced the problem with ubiquity 20.04.15 in focal and have verified that the version of ubiquity 20.04.15.1 in -proposed fixes the issue.

Marking as verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubiquity - 20.04.15.1

---------------
ubiquity (20.04.15.1) focal; urgency=medium

  [ Sebastien Bacher ]
  * debian/real-po: updated translations from launchpad, including strings
    from the new subpage for RST (LP: #1874103)

  [ Michael Hudson-Doyle ]
  * make grub_default consider the boot argument in the non-removable case
    (LP: #1847898)

  [ Jean-Baptiste Lallement ]
  * Enable ZFS autotrim (LP: #1883686)
  * Use persistent path for pool's vdevs (LP: #1880869)
  * Do not export all pools (LP: #1875045)

  [ Dimitri John Ledkov ]
  * ubiquity-dm: start gsd-keyboard for keyboard indicator (LP: #1847307)

 -- Dimitri John Ledkov <email address hidden> Tue, 16 Jun 2020 11:17:42 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for ubiquity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.