nm-tray edit connections fails because xterm is not installed

[ԜаӀtеr Ⅼарсһуnѕkі]

Running on the 20180813 daily image of Lubuntu, if you click the context menu for nm-tray, there's an edit connections option, which seems to run `xterm -e nmtui-edit` which would be fine, except for xterm is not installed. It should be using x-terminal-emulator instead.

Running nm-tray in terminal reveals the issue:
nm-tray: starting connection editor ("xterm", "-e", "nmtui-edit")
nm-tray: connection editor ("xterm", "-e", "nmtui-edit") failed, error= QProcess::ProcessError(FailedToStart)

ProblemType: Bug
DistroRelease: Ubuntu 18.10
Package: nm-tray 0.4.0-0ubuntu1
ProcVersionSignature: Ubuntu 4.17.0-6.7-generic 4.17.9
Uname: Linux 4.17.0-6-generic x86_64
ApportVersion: 2.20.10-0ubuntu7
Architecture: amd64
CurrentDesktop: LXQt
Date: Tue Aug 14 09:20:36 2018
InstallationDate: Installed on 2018-08-14 (0 days ago)
InstallationMedia: Lubuntu 18.10 "Cosmic Cuttlefish" - Alpha amd64 (20180813)
SourcePackage: nm-tray
UpgradeStatus: No upgrade log present (probably fresh install)

[ԜаӀtеr Ⅼарсһуnѕkі (wxl)]

So upstream pretty much hardcodes this in to /usr/share/nm-tray/nm-tray.conf:
https://github.com/palinek/nm-tray/blob/master/resources/nm-tray.conf#L2

Unfortunately, replacing xterm with qterminal results in some weird display issues that don't exist in xterm. See the comparison in the attachments.

[ԜаӀtеr Ⅼарсһуnѕkі (wxl)]

The problem: window's not big enough. Our default is somehow 640x480 while upstream default (for the past 8 years!) has been 800x600:
https://github.com/lxqt/qterminal/blame/master/src/config.h#L68

So the fix is two-fold:

1. Modify /etc/xdg/xdg-Lubuntu/qterminal.org/qterminal.ini from lubuntu-default-settings to include (yes, I've tested that only this is necessary):
[MainWindow]
size=@Size(800 600)

2. Modify /usr/share/nm-tray/nm-tray.conf from nm-tray such that xterm is replaced with qterminal. Both use the same -e switch so no other changes are necessary.

[Lugito (lugito)]

This bug has been marked as fixed in the Git repository: https://phab.lubuntu.me/rNMTRAYPACKAGINGafdd57457dbc
The commit message is the following: Use x-terminal-emulator in lieu of xterm for connection editing. (LP: #1786978)

(Note: I am only a bot. If this message was received in error, please contact my owners on the Lubuntu Team.)

[Simon Quigley (tsimonq2)]

This bug was fixed in the package lubuntu-default-settings - 1.9

---------------
lubuntu-default-settings (1.9) cosmic; urgency=medium

  [ Simon Quigley ]
  * We use Falkon now, not Qupzilla (LP: #1786986).

  [ Walter Lapchynski ]
  * Set qterminal window size to upstream default. (LP: #1786978)

 -- Simon Quigley <email address hidden> Thu, 16 Aug 2018 13:20:33 -0500

[Launchpad Janitor (janitor)]

This bug was fixed in the package nm-tray - 0.4.0-0ubuntu2

---------------
nm-tray (0.4.0-0ubuntu2) cosmic; urgency=medium

  [ Simon Quigley ]
  * Update Vcs-* for the new location.

  [ Walter Lapchynski ]
  * generalize-terminal-for-edits.patch: Use x-terminal-emulator in lieu of
    xterm for connection editing. (LP: #1786978)

 -- Simon Quigley <email address hidden> Thu, 16 Aug 2018 01:11:08 -0500