snapcraft.yaml: mv: cannot stat 'unpack/lib/firmware/brcm80211/brcm/*': No such file or directory

[Paolo Pisati]

Impact:

the Xenial/raspi2 kernel fails to generate a kernel snap since the wifi fw files are now part of linux-firmware and were removed from raspberrypi-wireless-firmware

How test it:

git clone the Xenial tree[1], checkout the raspi2 branch and try to snap it:

$ git clone git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial
$ cd linux
$ git checkout raspi2
linux$ snapcraft --target-arch=arm
...
Preparing to build raspiwififw
Building raspiwififw
--2018-08-02 15:04:14-- http://ppa.launchpad.net/snappy-dev/image/ubuntu/pool/main/r/raspberrypi-wireless-firmware/raspberrypi-wireless-firmware_2.0.1_armhf.deb
Resolving ppa.launchpad.net (ppa.launchpad.net)... 91.189.95.83
Connecting to ppa.launchpad.net (ppa.launchpad.net)|91.189.95.83|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 8568 (8.4K) [application/x-debian-package]
Saving to: ‘raspberrypi-wireless-firmware_2.0.1_armhf.deb’

raspberrypi-wireless-firmware_2.0.1_a 100%[=========================================================================>] 8.37K --.-KB/s in 0s

2018-08-02 15:04:14 (114 MB/s) - ‘raspberrypi-wireless-firmware_2.0.1_armhf.deb’ saved [8568/8568]

mv: cannot stat 'unpack/lib/firmware/brcm80211/brcm/*': No such file or directory
Failed to run 'install': Exit code was 1.

Apply the attached patch and redo the above steps: you will get a kernel snap now.

Regression:

None, it actually fixes the kernel snap creation

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-raspi2 - 4.4.0-1096.104

---------------
linux-raspi2 (4.4.0-1096.104) xenial; urgency=medium

  * linux-raspi2: 4.4.0-1096.104 -proposed tracker (LP: #1788772)

  * snapcraft.yaml: Parts cannot contain both 'install' and 'override-*'
    keywords. (LP: #1785647)
    - snapcraft.yaml: convert prepare, build and install to override-build

  * Support for the RaspberryPi 3 B Plus board (LP: #1784025)
    - BCM270X_DT: Add Pi 3+ dts files
    - SAUCE: dts: remove i2c_dsi reference (4.9+ only)
    - SAUCE: dts: use 0 instead of GPIO_ACTIVE_LOW
    - SAUCE: dts: remove the hdmi node since it's part of the vc4 overlay
    - SAUCE: dts: use the virtgpio driver
    - SAUCE: fix address & size of reg cell for usb1
    - modules: remove lan78xx and microchip phy check
    - SAUCE: Revert "lan78xx: Correctly indicate invalid OTP"
    - lan78xx: Read MAC address from DT if present
    - lan78xx: Enable LEDs if no valid EEPROM or OTP
    - lan78xx: Read initial EEE status from DT
    - lan78xx: Change LEDs to include 10Mb activity
    - lan78xx: Read LED states from Device Tree
    - lan78xx: Ignore DT MAC address if already valid
    - net: lan78xx: Allow for VLAN headers in timeout.
    - lan78xx: Connect phy early
    - lan78xx: Don't reset the interface on open
    - lan78xx: Move enabling of EEE into PHY init code
    - brcmfmac: Disable runtime pm for USB.
    - brcmfmac: Fix double free on exception at module load.
    - brcmfmac: only lock and unlock fws if fws is not null
    - brcmfmac: Fix warn trace on module unload while in ibss mode
    - brcmfmac: fix p2p scan abort null pointer exception
    - brcmf: Fix null pointer exception in bcdc_hdrpull
    - brcmfmac: Return actual error by fwil.
    - brcmfmac: sdio: Increase the default timeouts a bit

  * snapcraft.yaml: mv: cannot stat 'unpack/lib/firmware/brcm80211/brcm/*': No
    such file or directory (LP: #1785075)
    - snapcraft.yaml: wifi fw files are now part of linux-firmware

  [ Ubuntu: 4.4.0-135.161 ]

  * linux: 4.4.0-135.161 -proposed tracker (LP: #1788766)
  * [Regression] APM Merlin boards fail to recover link after interface down/up
    (LP: #1785739)
    - net: phylib: fix interrupts re-enablement in phy_start
    - net: phy: fix phy_start to consider PHY_IGNORE_INTERRUPT
  * qeth: don't clobber buffer on async TX completion (LP: #1786057)
    - s390/qeth: don't clobber buffer on async TX completion
  * nvme: avoid cqe corruption (LP: #1788035)
    - nvme: avoid cqe corruption when update at the same time as read
  * CacheFiles: Error: Overlong wait for old active object to go away.
    (LP: #1776254)
    - cachefiles: Fix missing clear of the CACHEFILES_OBJECT_ACTIVE flag
    - cachefiles: Wait rather than BUG'ing on "Unexpected object collision"
  * fscache cookie refcount updated incorrectly during fscache object allocation
    (LP: #1776277) // fscache cookie refcount updated incorrectly during fscache
    object allocation (LP: #1776277)
    - fscache: Fix reference overput in fscache_attach_object() error handling
  * FS-Cache: Assertion failed: FS-Cache: 6 == 5 is false (LP: #1774336)
    - Revert "UBUNTU: SAUCE: CacheFiles: fix a...