Minor unit Test regression in 1.2.15

[Julian Andres Klode]

In 1.2.15 the unit tests (which run at build time) fail with an error message in the atomic files test, because I picked a commit that improved the error handling a bit (a previous error now propagates into further calls):

/<<PKGBUILDDIR>>/test/libapt/fileutl_test.cc:376: Failure
Value of: f.Close()
  Actual: false
Expected: true

I'll revert that for 1.2.16, as it depends on another fix, and I'm not sure I really want those two in there.

[Impact]
* Causes unit test failure, but might not have real effects

[Test Case]
* Check that build output (which runs unit tests) contains no failure

[Regression Potential]
* None, we are just reverting a commit from 1.2.15, so we have the same as in 1.2.14

[Julian Andres Klode (juliank)]

This never affected any other release than xenial

[Julian Andres Klode (juliank)]

The issue is:

/<<PKGBUILDDIR>>/test/libapt/fileutl_test.cc:376: Failure
Value of: f.Close()
  Actual: false
Expected: true

Note that the test suite is not guaranteed to run during the build - there are dependency tracking issues in the build system, causing it to not build sometimes. But where it builds, this error should be gone.

[Adam Conrad (adconrad)]

Hello Julian, or anyone else affected,

Accepted apt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.2.18 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Julian Andres Klode (juliank)]

Confirming fixed in 1.2.18

[Launchpad Janitor (janitor)]

This bug was fixed in the package apt - 1.2.18

---------------
apt (1.2.18) xenial; urgency=high

  * SECURITY UPDATE: gpgv: Check for errors when splitting files (CVE-2016-1252)
    Thanks to Jann Horn, Google Project Zero for reporting the issue
    (LP: #1647467)
  * gpgv: Flush the files before checking for errors

apt (1.2.17) xenial; urgency=medium

  [ David Kalnischkies ]
  * apt-key: warn instead of fail on unreadable keyrings (LP: #1642386)
  * show apt-key warnings in apt update (Closes: 834973)

  [ Julian Andres Klode ]
  * test-releasefile-verification: installaptold: Clean up before run

apt (1.2.16) xenial; urgency=medium

  [ David Kalnischkies ]
  * avoid changing the global LC_TIME for Release writing
  * use de-localed std::put_time instead rolling our own
  * accept only the expected UTC timezones in date parsing (Closes: 819697)
  * avoid std::get_time usage to sidestep libstdc++6 bug (LP: #1593583)
  * imbue datetime parsing with C.UTF-8 locale (Closes: 828011)
  * prevent C++ locale number formatting in text APIs (try 2) (Closes: 832044)
  * prevent C++ locale number formatting in text APIs (try 3) (LP: #1611010)
    (LP: #1592817)
  * imbue .diff/Index parsing with C.UTF-8 as well

  [ Julian Andres Klode ]
  * Use C locale instead of C.UTF-8 for protocol strings
  * Add shippable.yml for CI on Shippable
  * Revert "if the FileFd failed already following calls should fail, too"
    (LP: #1641905)

 -- Julian Andres Klode <email address hidden> Thu, 08 Dec 2016 15:28:08 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for apt has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.