[SRU] thunar crashes on file renaming
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Thunar File Manager |
Fix Released
|
High
|
|||
thunar (Ubuntu) |
Fix Released
|
High
|
Marcos Nascimento | ||
Xenial |
Fix Released
|
Undecided
|
Sean Davis | ||
Yakkety |
Fix Released
|
Undecided
|
Sean Davis | ||
Zesty |
Fix Released
|
High
|
Marcos Nascimento |
Bug Description
[Impact]
* Thunar crashes frequently when renaming files.
* All open Thunar windows are closed, disrupting a user's workflow.
* There have been several patches addressing this issue since the bug
was originally reported, and numerous users are now reporting that
the issue is resolved.
[Test Case]
* Backup the file you will be testing to a different location.
* Rename or move a file several times. When present, the bug may cause
Thunar to crash on the first rename or after several.
[Regression Potential]
* The patches have not been tested in all possible configurations,
and could result in unexpected behavior (possibly additional crashing).
* However, with the frequency that this bug crashes Thunar with the
existing package, any reduction in the number of crashes are welcome.
* Since Thunar is a file manager, there is a risk of data loss when
testing this bug and potentially instigating a crash.
[Original Report]
When renaming files in a folder while re-sorting similarly named files, thunar crashes fairly often. Apport does not detect the crashes.
Running thunar in valgrind produces these log entries in the moment of the crash:
==28859== Thread 1:
==28859== Invalid read of size 1
==28859== at 0x04c2ffd3: strcmp (in /usr/lib/
==28859== by 0x0014590c: thunar_
==28859== by 0x00153e3d: thunar_
==28859== by 0x07e4da23: ??? (in /lib/x86_
==28859== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==28859==
==28859== Process terminating with default action of signal 11 (SIGSEGV)
==28859== Access not within mapped region at address 0x0
==28859== at 0x04c2ffd3: strcmp (in /usr/lib/
==28859== by 0x0014590c: thunar_
==28859== by 0x00153e3d: thunar_
==28859== by 0x07e4da23: ??? (in /lib/x86_
==28859== If you believe this happened as a result of a stack
==28859== overflow in your program's main thread (unlikely but
==28859== possible), you can try to increase the size of the
==28859== main thread stack using the --main-stacksize= flag.
==28859== The main thread stack size used in this run was 8388608.
==28859==
==28859== HEAP SUMMARY:
==28859== in use at exit: 11,169,056 bytes in 101,668 blocks
==28859== total heap usage: 8,917,549 allocs, 8,815,881 frees, 736,520,410 bytes allocated
==28859==
==28859== For counts of detected and suppressed errors, rerun with: -v
==28859== Use --track-origins=yes to see where uninitialised values come from
==28859== ERROR SUMMARY: 1046 errors from 45 contexts (suppressed: 0 from 0)
==28859==
ProblemType: Bug
DistroRelease: Ubuntu 15.10
Package: thunar 1.6.10-1
ProcVersionSign
Uname: Linux 4.2.0-16-generic x86_64
ApportVersion: 2.19.1-0ubuntu4
Architecture: amd64
CurrentDesktop: XFCE
Date: Sun Nov 1 18:57:09 2015
InstallationDate: Installed on 2015-02-05 (268 days ago)
InstallationMedia: Xubuntu 15.04 "Vivid Vervet" - Alpha amd64 (20150205)
SourcePackage: thunar
UpgradeStatus: Upgraded to wily on 2015-05-28 (156 days ago)
Changed in thunar: | |
importance: | Unknown → High |
status: | Unknown → Confirmed |
Changed in thunar (Ubuntu): | |
importance: | Undecided → High |
tags: | added: iso-testing |
information type: | Public → Public Security |
information type: | Public Security → Private Security |
information type: | Private Security → Public |
tags: | added: yakkety |
tags: | added: package-qa-testing |
Changed in thunar (Ubuntu): | |
assignee: | nobody → Marcos (wstlmn) |
Changed in thunar: | |
status: | Confirmed → Fix Released |
Changed in thunar (Ubuntu Zesty): | |
status: | Confirmed → Fix Released |
description: | updated |
summary: |
- thunar crashes on file renaming + [SRU] thunar crashes on file renaming |
Changed in thunar (Ubuntu Xenial): | |
status: | New → In Progress |
Changed in thunar (Ubuntu Yakkety): | |
status: | New → In Progress |
Changed in thunar (Ubuntu Xenial): | |
assignee: | nobody → Sean Davis (bluesabre) |
Changed in thunar (Ubuntu Yakkety): | |
assignee: | nobody → Sean Davis (bluesabre) |
Changed in thunar (Ubuntu Yakkety): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed |
Changed in thunar (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done removed: verification-needed |
tags: |
added: verification-done-xenial verification-done-yakkety removed: verification-done |
Changed in thunar (Ubuntu Xenial): | |
status: | Fix Committed → Fix Released |
Changed in thunar (Ubuntu Yakkety): | |
status: | Fix Committed → Fix Released |
Created attachment 6482
Backtrace
Thunar randomly crashes (SIGSEGV) when renaming files.
Reproducible: Random
Steps to Reproduce:
1. Start up Thunar.
2. Go to some directory with single file.
3. Rename that file
4. Change the filename and press enter.
5. Not crashed? Try step 3 again.
Crashes even for single file in whole folder. It is strange that if you run it with gdb then the crash is not so often.
gdb backtrace attached - it is strange that the thunar_ file_compare_ by_name( ) function is called even for only one file in working directory - both file_a- >collate_ key_nocase and file_b- >collate_ key_nocase are NULL. I noticed that sometimes this function is not called, but when it is (it is random), then it crashes.