backport of driver for I2C on Sunrisepoint PCH

[Jesse Sung]

Some newly released laptops talk to touchpad via I2C to provide advanced functions. The new Intel Skylake uses Sunrisepoint PCH, thus the I2C on it needs to to enabled in order to support these touchpads.

Intel is still working on the driver. There are six versions so far:
v1: https://lkml.org/lkml/2015/3/31/255
v2: https://lkml.org/lkml/2015/5/25/298
v3: https://lkml.org/lkml/2015/6/1/429
v4: https://lkml.org/lkml/2015/6/15/160
v5: https://lkml.org/lkml/2015/7/6/317
v6: https://lkml.org/lkml/2015/7/27/599

The driver supports SPI, UART, and I2C on the Sunrisepoint PCH, but we'll only focus on the I2C part.

[Jesse Sung (wenchien)]

The v6 patchset is in subsystem maintainer's tree, bc0195aa..4b45efe8 of
https://git.kernel.org/cgit/linux/kernel/git/lee/mfd.git/log/?h=ib-mfd-base-acpi-dma-4.3

[Jesse Sung (wenchien)]

Since merge window for 4.3 is opened, all of these commits are in linus' tree now.

[Jesse Sung (wenchien)]

Tests was done with two different Skylake systems (one with ELAN i2c touchpad, and the other with Synaptics), and randomly picked AMD, IvyBridge, Haswell, and Broadwell systems.

Each of them went through 30 reboots, and see if every hardware components, especially touchpad, still work after each boot.

Skylake1 (ELAN - i2c) : Passed (Failed once *1)
Skylake2 (Synaptics - i2c) : Passed
AMD (Cypress - PS/2) : Passed
IvyBridge (Synaptics - PS/2) : Passed
Haswell (Synaptics - I2C) : Passed
Broadwell (ALPS - PS/2) : Passed

*1
When this happns, i2c_hid failed to communicate with touchpad. Thus touchpad still worked as a PS/2 mouse.
[ 11.858424] i2c_hid i2c-DLL06FD:01: hid_descr_cmd failed
Touchpad switched to i2c mode after reloading i2c_hid.
[ 402.635558] i2c_hid i2c-DLL06FD:01: error in i2c_hid_init_report size:633 / ret_size:7
[ 402.638143] i2c_hid i2c-DLL06FD:01: error in i2c_hid_init_report size:69 / ret_size:7
[ 402.648983] input: DLL06FD:01 04F3:300F UNKNOWN as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-4/i2c

[Brad Figg (brad-figg)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-vivid' to 'verification-done-vivid'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Jesse Sung (wenchien)]

Verified with both Skylake1 and Skylake2 in #3.

[Pascal Morin (pcm689)]

Jesse,

Was the verification successful or failed?

Thank you

Pascal Morin -
On 23/09/2015 23:10, Jesse Sung wrote:
> Verified with both Skylake1 and Skylake2 in #3.
>
> ** Tags removed: verification-needed-vivid
> ** Tags added: verification-done-vivid
>

[Jesse Sung (wenchien)]

It was successful. Touchpads of Skylake1 and Skylake2 operated in i2c
mode via MFD LPSS driver as expected.

Thanks,
jesse

2015-09-24 8:44 GMT+08:00 Pascal Morin <email address hidden>:
> Jesse,
>
> Was the verification successful or failed?
>
> Thank you
>
> Pascal Morin -
> On 23/09/2015 23:10, Jesse Sung wrote:
>> Verified with both Skylake1 and Skylake2 in #3.
>>
>> ** Tags removed: verification-needed-vivid
>> ** Tags added: verification-done-vivid
>>
>

[Pascal Morin (pcm689)]

Jesse,

Wonderful news!

Thank you

Pascal Morin -
On 24/09/2015 09:21, Jesse Sung wrote:
> It was successful. Touchpads of Skylake1 and Skylake2 operated in i2c
> mode via MFD LPSS driver as expected.
>
> Thanks,
> jesse
>
> 2015-09-24 8:44 GMT+08:00 Pascal Morin <email address hidden>:
>> Jesse,
>>
>> Was the verification successful or failed?
>>
>> Thank you
>>
>> Pascal Morin -
>> On 23/09/2015 23:10, Jesse Sung wrote:
>>> Verified with both Skylake1 and Skylake2 in #3.
>>>
>>> ** Tags removed: verification-needed-vivid
>>> ** Tags added: verification-done-vivid
>>>

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 3.19.0-30.33

---------------
linux (3.19.0-30.33) vivid; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #1498065
  * Revert "[Config]
    MFD_INTEL_LPSS/MFD_INTEL_LPSS_ACPI/MFD_INTEL_LPSS_PCI=m"
    - LP: #1498137
  * [Config] Disable the MFD_INTEL_LPSS* driver

linux (3.19.0-30.32) vivid; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #1498065

  [ Upstream Kernel Changes ]

  * net: Fix skb_set_peeked use-after-free bug
    - LP: #1497184

linux (3.19.0-29.31) vivid; urgency=low

  [ Luis Henriques ]

  * Release Tracking Bug
    - LP: #1493902

  [ Ander Conselvan de Oliveira ]

  * SAUCE: i915_bpo: Set ddi_pll_sel in DP MST path
    - LP: #1483320

  [ Chris J Arges ]

  * [Config] DEFAULT_IOSCHED="deadline" for ppc64el
    - LP: #1469829

  [ Chris Wilson ]

  * SAUCE: i915_bpo: drm/i915: Flag the execlists context object as dirty
    after every use
    - LP: #1489501

  [ Daniel Vetter ]

  * SAUCE: i915_bpo: drm/i915: Only dither on 6bpc panels
    - LP: #1489501

  [ David Henningsson ]

  * SAUCE: drm/i915: Add audio pin sense / ELD callback
    - LP: #1490895
  * SAUCE: drm/i915: Call audio pin/ELD notify function
    - LP: #1490895
  * SAUCE: ubuntu/i915: Call audio pin/ELD notify function
    - LP: #1490895
  * SAUCE: ALSA: hda - Add "hdac_acomp" global variable
    - LP: #1490895
  * SAUCE: ALSA: hda - allow codecs to access the i915 pin/ELD callback
    - LP: #1490895
  * SAUCE: ALSA: hda - Wake the codec up on pin/ELD notify events
    - LP: #1490895

  [ Jani Nikula ]

  * SAUCE: i915_bpo: Revert "drm/i915: Allow parsing of variable size child
    device entries from VBT"
    - LP: #1489501

  [ Maarten Lankhorst ]

  * SAUCE: i915_bpo: drm/i915: calculate primary visibility changes instead
    of calling from set_config
    - LP: #1489501
  * SAUCE: i915_bpo: drm/i915: Commit planes on each crtc separately.
    - LP: #1489501

  [ Thulasimani,Sivakumar ]

  * SAUCE: i915_bpo: Revert "drm/i915: Add eDP intermediate frequencies for
    CHV"
    - LP: #1489501
  * SAUCE: i915_bpo: drm/i915: remove HBR2 from chv supported list
    - LP: #1489501
  * SAUCE: i915_bpo: drm/i915: Avoid TP3 on CHV
    - LP: #1489501

  [ Timo Aaltonen ]

  * Revert "SAUCE: i915_bpo: drm/i915: Allow parsing of variable size child
    device entries from VBT, addendum v2"
    - LP: #1489501
  * SAUCE: Migrate Broadwell to i915_bpo.
    - LP: #1483320

  [ Upstream Kernel Changes ]

  * tcp: fix recv with flags MSG_WAITALL | MSG_PEEK
    - LP: #1486146
  * powerpc/powernv: Fix the overflow of OPAL message notifiers head array
    - LP: #1487085
  * xhci: call BIOS workaround to enable runtime suspend on Intel Braswell
    - LP: #1489292
  * PM / QoS: Make it possible to expose device latency tolerance to
    userspace
    - LP: #1488395
  * ACPI / PM: Attach ACPI power domain only once
    - LP: #1488395
  * Driver core: wakeup the parent device before trying probe
    - LP: #1488395
  * klist: implement klist_prev()
    - LP: #1488395
  * driver core: implement device_for_each_child_reverse()
    - LP: #1488395
  * mfd: make mfd_remove_devices() iterate in reverse order
    ...

[Anthony Wong (anthonywong)]

Thanks for closing hwe-next!

[Sent via Android Gmail]

On 11 Dec 2016 15:29, "Jesse Sung" <email address hidden> wrote:

> ** Changed in: hwe-next
> Status: In Progress => Fix Released
>
> --
> You received this bug notification because you are subscribed to HWE
> Next.
> Matching subscriptions: d65410eed259611873c6b80faee42127
> https://bugs.launchpad.net/bugs/1488395
>
> Title:
> backport of driver for I2C on Sunrisepoint PCH
>
> Status in HWE Next:
> Fix Released
> Status in linux package in Ubuntu:
> Invalid
> Status in linux source package in Vivid:
> Fix Released
>
> Bug description:
> Some newly released laptops talk to touchpad via I2C to provide
> advanced functions. The new Intel Skylake uses Sunrisepoint PCH, thus
> the I2C on it needs to to enabled in order to support these touchpads.
>
> Intel is still working on the driver. There are six versions so far:
> v1: https://lkml.org/lkml/2015/3/31/255
> v2: https://lkml.org/lkml/2015/5/25/298
> v3: https://lkml.org/lkml/2015/6/1/429
> v4: https://lkml.org/lkml/2015/6/15/160
> v5: https://lkml.org/lkml/2015/7/6/317
> v6: https://lkml.org/lkml/2015/7/27/599
>
> The driver supports SPI, UART, and I2C on the Sunrisepoint PCH, but
> we'll only focus on the I2C part.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/hwe-next/+bug/1488395/+subscriptions
>