Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/trunk-bug-791452-psi into lp:openobject-addons

  1. trunk-bug-791452-psi
  2. Merge into trunk
Proposed by Purnendu Singh (OpenERP)
Status: Rejected
Rejected by: qdp (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-791452-psi
Merge into: lp:openobject-addons
Diff against target: 11 lines (+1/-1)
1 file modified
account/report/account_balance_sheet.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-791452-psi
Reviewer Review Type Date Requested Status
qdp (OpenERP) Needs Information
Mustufa Rangwala (Open ERP) (community) Approve
Review via email: mp+63647@code.launchpad.net

Description of the change

Hello,

Fixes: https://bugs.launchpad.net/openobject-addons/+bug/791452
Description: Incorrect balance sheet due to the changes in m2o field of osv.memory

Due to the improvement in m2o field of osv.memory Reserve & Profit/Loss account line is not added in Balance Sheet report.

Thanks,
Purnendu Singh

To post a comment you must log in.
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) :
review: Approve
Revision history for this message
qdp (OpenERP) (qdp) wrote :

huuuu

i think we talked about removing the reserve_profit_loss account from res.company and wizard. Mustufa, can you remind me?

review: Needs Information
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Yes Quentin,

We have discussed this but before that this MP got approved.

https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-722832-psi/+merge/64809 it is removed here.

Thanks,
Mustufa

Revision history for this message
qdp (OpenERP) (qdp) wrote :

ok then, it's rejected

Unmerged revisions

4771. By dsh (Open ERP)

[FIX] account: Reserve & Profit/Loss account line missing in Balance Sheet report

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/report/account_balance_sheet.py'
2--- account/report/account_balance_sheet.py 2011-05-02 18:46:43 +0000
3+++ account/report/account_balance_sheet.py 2011-06-07 07:06:39 +0000
4@@ -151,7 +151,7 @@
5 accounts_temp.append(account_dict)
6 else:
7 accounts_temp.append(account_dict)
8- if account.id == data['form']['reserve_account_id']:
9+ if account.id == data['form']['reserve_account_id'][0]:
10 pl_dict['level'] = account['level'] + 1
11 accounts_temp.append(pl_dict)
12

Subscribers

People subscribed via source and target branches

to all changes: