Merge lp:~openerp-dev/openobject-addons/trunk-bug-787052-mma into lp:openobject-addons
Proposed by
Mayur Maheshwari(OpenERP)
| Status: | Merged |
|---|---|
| Merged at revision: | 5166 |
| Proposed branch: | lp:~openerp-dev/openobject-addons/trunk-bug-787052-mma |
| Merge into: | lp:openobject-addons |
| Diff against target: |
24 lines (+2/-1) 2 files modified
multi_company/multi_company_demo.xml (+1/-1) purchase/purchase_sequence.xml (+1/-0) |
| To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-787052-mma |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rucha (Open ERP) (community) | Approve | ||
| Mayur Maheshwari(OpenERP) (community) | Needs Resubmitting | ||
| qdp (OpenERP) | Pending | ||
|
Review via email:
|
|||
Description of the change
Hello
multi_company : Adding a file for a purchase order sequence and add a Demo Data for company
shop1 and shop2
purchase : modified sql constraint
Thanks
To post a comment you must log in.
Revision history for this message
| Mayur Maheshwari(OpenERP) (mma-openerp) wrote | # |
review:
Needs Resubmitting
Revision history for this message
| Mayur Maheshwari(OpenERP) (mma-openerp) wrote | # |
review:
Needs Resubmitting
Revision history for this message
| Rucha (Open ERP) (rpa-openerp) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
this seems not a proper fix as these changes are of purchase and in the dependency of this module (multi_company) there is no reference to purchase (though this fix doesn't break anything by traceback), so its good to fix the problem in purchase module itself,
- No need to change unique constraint of PO name (user can configure sequence so that its not conflicting with other names)
also this is not a good to refer company in data/update xml which is loaded in demo as it will give error of reference for the database without demo,
please improve it,
thanks