Odoo Addons (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-addons/trunk-bug-1010426-mma into lp:openobject-addons

  1. trunk-bug-1010426-mma
  2. Merge into trunk
Proposed by Mayur Maheshwari(OpenERP)
Status: Rejected
Rejected by: Harry (OpenERP)
Proposed branch: lp:~openerp-dev/openobject-addons/trunk-bug-1010426-mma
Merge into: lp:openobject-addons
Diff against target: 21 lines (+2/-2)
1 file modified
stock/product_view.xml (+2/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-addons/trunk-bug-1010426-mma
Reviewer Review Type Date Requested Status
Mayur Maheshwari(OpenERP) (community) Needs Resubmitting
Purnendu Singh (OpenERP) (community) Needs Fixing
Review via email: mp+109587@code.launchpad.net

Description of the change

Hello Sir,

      stock: I Have fix the issue of to open a links of receptions and deliveries from kanban view

Thanks.
Mayur

To post a comment you must log in.
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello Mayur,

Well done but it can be improve a little bit!!!

Say for example Kanban or Ice Cream shows Receptions(2) Deliveries(3) but if we click on Receptions(2) it will show all the receptions but user expected only 2 receptions which will make the user confuse!!!

So, Apply proper domain.

Thanks,
purnendu Singh

review: Needs Fixing
Revision history for this message
Mayur Maheshwari(OpenERP) (mma-openerp) wrote :

Hello Sir ,

      I have improve domain of action as per the count of [Receptions(2) Deliveries(3)]

      Kindly review it

Thanks.
Mayur

review: Needs Resubmitting

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock/product_view.xml'
2--- stock/product_view.xml 2012-06-19 08:56:18 +0000
3+++ stock/product_view.xml 2012-06-21 11:42:23 +0000
4@@ -130,7 +130,7 @@
5 <field name="type">ir.actions.act_window</field>
6 <field name="view_type">form</field>
7 <field name="view_mode">tree,form</field>
8- <field name="domain">[('product_id','=',active_id),('picking_id.type','=','in')]</field>
9+ <field name="domain">[('picking_id.type','=','in'),('state','not in',['cancel','done'])]</field>
10 <field name="view_id" ref="view_move_tree_reception_picking"/>
11 <field name="context" eval="'{\'search_default_product_id\': [active_id]}'"/>
12 <field name="search_view_id" ref="view_move_search_reception_incoming_picking"/>
13@@ -143,7 +143,7 @@
14 <field name="type">ir.actions.act_window</field>
15 <field name="view_type">form</field>
16 <field name="view_mode">tree,form</field>
17- <field name="domain">[('product_id','=',active_id),('picking_id.type','=','out')]</field>
18+ <field name="domain">[('picking_id.type','=','out'),('state','not in',['cancel','done'])]</field>
19 <field name="view_id" ref="view_move_tree_reception_picking"/>
20 <field name="context" eval="'{\'search_default_product_id\': [active_id]}'"/>
21 <field name="search_view_id" ref="view_move_search_reception_outcoming_picking"/>

Subscribers

People subscribed via source and target branches

to all changes: