Merge lp:~omacneil/mvhub/cron_script_to_set_program_max_last_update_1277300 into lp:~rpulaparti/mvhub/cron_script_to_set_program_max_last_update_1277300
Status: | Merged |
---|---|
Merged at revision: | 686 |
Proposed branch: | lp:~omacneil/mvhub/cron_script_to_set_program_max_last_update_1277300 |
Merge into: | lp:~rpulaparti/mvhub/cron_script_to_set_program_max_last_update_1277300 |
Diff against target: |
459 lines (+93/-132) 15 files modified
app-mvhub/DocumentRoot/static/mvh/html/links.shtml (+1/-6) app-mvhub/DocumentRoot/static/mvh/inc/footer.inc (+1/-1) app-mvhub/DocumentRoot/static/nsp/html/links.shtml (+8/-13) app-mvhub/DocumentRoot/static/nsp/inc/footer.inc (+1/-1) app-mvhub/bin/sync_program_update_dates (+7/-4) app-mvhub/bin/sync_program_update_dates_and_send_notification_email (+6/-2) app-mvhub/conf/sql_select.lib (+20/-10) app-mvhub/conf/sql_update.lib (+1/-2) app-mvhub/project-tools/templates/template.conf (+1/-0) app-mvhub/setup/etc/cron.d/mvhub-cron (+3/-3) lib-mvhub/lib/MVHub.pm (+2/-2) lib-mvhub/lib/MVHub/Utils/SyncProgramUpdateDates.pm (+26/-69) lib-mvhub/t/Utils/SyncProgramUpdateDates/sync_program_dates.t (+14/-19) lib-mvhub/t/conf/all.conf (+1/-0) lib-mvhub/t/lib/TestData.pm (+1/-0) |
To merge this branch: | bzr merge lp:~omacneil/mvhub/cron_script_to_set_program_max_last_update_1277300 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
RPulaparti | Pending | ||
Review via email: mp+265915@code.launchpad.net |
Description of the change
merged trunk
eleminated some branches / duplicate code
better complies with wiki.thecsl.
added path config so scripts run from more than ./
added exit 0 so sripts return NO_ERROR if they get to the end without trouble
changed SQL so print and do can use the same queries and what is printed is what is updated to facilitate eyeball sanity check / dry running
BUGS:
I added a lot of over-head calling sub routines and doing individual SQL UPDATE statements. If we were updating millions instead of 10s of records, this would be a big deal. As it is, the sync_* scripts take less than a second to run.
TDOO
You will have to run:
mv_update_
to bring the conf file changes into your enviroment.
You might run in the --execute mode and eyeball the datbase before and after , by our design it runs without feedback ( so as not to force cron to send emails when everything works)
Everytime you run:
mv_update_
...it refreshes the big postgresql test data.