Ubuntu
puppet package

Merge lp:~lynxman/ubuntu/oneiric/puppet/lp_854899 into lp:ubuntu/oneiric/puppet

  1. Oneiric (11.10)
  2. lp_854899
  3. Merge into oneiric
Proposed by Marc Cluet
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~lynxman/ubuntu/oneiric/puppet/lp_854899
Merge into: lp:ubuntu/oneiric/puppet
Diff against target: 108 lines (+37/-18)
4 files modified
debian/changelog (+18/-0)
debian/patches/debian-changes (+8/-18)
debian/patches/fix_logcheck (+10/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~lynxman/ubuntu/oneiric/puppet/lp_854899
Reviewer Review Type Date Requested Status
Marc Deslauriers Disapprove
Ubuntu branches Pending
Review via email: mp+76267@code.launchpad.net

Description of the change

* Merge with upstream debian

To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) wrote :

Whilst the FFe hasn't been accepted.. a quick look suggests the debian/changelog could use more detail, such as what Ubuntu changes remain - and if some were dropped, why?

Also the bug number in the format of LP: #854899

Do all the current ubuntu patches cleanly apply and unapply?

Revision history for this message
Marc Cluet (lynxman) wrote :

1. Nothing was dropped from the Ubuntu changes, just the part maintaned by debian was upgraded verbatim

2. All Ubuntu patches do cleanly apply and unapply, no issues

lp:~lynxman/ubuntu/oneiric/puppet/lp_854899 updated
53. By Marc Cluet

* Modified changelog to reflect LP bug number (LP: #854899)

Revision history for this message
Colin Watson (cjwatson) wrote :

On Tue, Sep 20, 2011 at 07:16:23PM -0000, Marc Cluet wrote:
> 1. Nothing was dropped from the Ubuntu changes, just the part maintaned by debian was upgraded verbatim

It's Ubuntu policy (https://wiki.ubuntu.com/UbuntuDevelopment/Merging)
to list the changes that are still outstanding every time we merge from
Debian. This makes sure we always have a current summary, and reminds
us to try to keep our unmerged delta as small as possible.

lp:~lynxman/ubuntu/oneiric/puppet/lp_854899 updated
54. By Marc Cluet

* Modified changelog to reflect Ubuntu diffs from debian upstream release

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

This was too late for Oneiric. Could you please change the merge request status? Thanks.

review: Disapprove

Unmerged revisions

54. By Marc Cluet

* Modified changelog to reflect Ubuntu diffs from debian upstream release

53. By Marc Cluet

* Modified changelog to reflect LP bug number (LP: #854899)

52. By Marc Cluet

* Merge with debian upstream (LP:#854899)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-07-25 01:00:37 +0000
3+++ debian/changelog 2011-09-20 20:52:23 +0000
4@@ -1,3 +1,21 @@
5+puppet (2.7.3-1ubuntu1) oneiric; urgency=low
6+
7+ * Merge from debian unstable (LP: #854899). Remaining changes:
8+ - debian/puppetmaster-passenger.postinst: Use cacrl instead of hostcrl to
9+ set the location of the CRL in apache2 configuration. Fix apache2
10+ configuration on upgrade as well (LP: #641001)
11+ - move all puppet dependencies to puppet-common since all the code
12+ actually located in puppet-common.
13+ - move libagueas from a recommend to a dependency.
14+
15+ -- Marc Cluet <marc.cluet@ubuntu.com> Tue, 20 Nov 2011 09:50:24 -0700
16+
17+puppet (2.7.3-1) unstable; urgency=low
18+
19+ * New upstream version
20+
21+ -- Stig Sandbeck Mathisen <ssm@debian.org> Tue, 16 Aug 2011 08:38:28 +0200
22+
23 puppet (2.7.1-1ubuntu1) oneiric; urgency=low
24
25 * Merge from debian unstable. Remaining changes:
26
27=== modified file 'debian/patches/debian-changes'
28--- debian/patches/debian-changes 2011-07-25 01:00:37 +0000
29+++ debian/patches/debian-changes 2011-09-20 20:52:23 +0000
30@@ -3,8 +3,8 @@
31 but it might have accumulated changes from several uploads. Please
32 check the changelog to (hopefully) learn more on those changes.
33
34---- puppet-2.7.1.orig/Rakefile
35-+++ puppet-2.7.1/Rakefile
36+--- puppet-2.7.3.orig/Rakefile
37++++ puppet-2.7.3/Rakefile
38 @@ -9,7 +9,7 @@ require 'rspec'
39 require "rspec/core/rake_task"
40
41@@ -14,16 +14,16 @@
42 end
43
44 Dir['tasks/**/*.rake'].each { |t| load t }
45---- puppet-2.7.1.orig/test/lib/puppettest/fakes.rb
46-+++ puppet-2.7.1/test/lib/puppettest/fakes.rb
47+--- puppet-2.7.3.orig/test/lib/puppettest/fakes.rb
48++++ puppet-2.7.3/test/lib/puppettest/fakes.rb
49 @@ -1,4 +1,4 @@
50 -require File.expand_path(File.join(File.dirname(__FILE__), '../../../lib/puppet/util'))
51 +require '/usr/lib/ruby/1.8/puppet/util'
52
53 module PuppetTest
54 # A baseclass for the faketypes.
55---- puppet-2.7.1.orig/lib/puppet/provider/service/init.rb
56-+++ puppet-2.7.1/lib/puppet/provider/service/init.rb
57+--- puppet-2.7.3.orig/lib/puppet/provider/service/init.rb
58++++ puppet-2.7.3/lib/puppet/provider/service/init.rb
59 @@ -134,7 +134,15 @@ Puppet::Type.type(:service).provide :ini
60 # we just return that; otherwise, we return false, which causes it to
61 # fallback to other mechanisms.
62@@ -41,8 +41,8 @@
63 end
64
65 end
66---- puppet-2.7.1.orig/ext/rack/files/apache2.conf
67-+++ puppet-2.7.1/ext/rack/files/apache2.conf
68+--- puppet-2.7.3.orig/ext/rack/files/apache2.conf
69++++ puppet-2.7.3/ext/rack/files/apache2.conf
70 @@ -1,12 +1,4 @@
71 -
72 -# you probably want to tune these settings
73@@ -97,13 +97,3 @@
74 Options None
75 AllowOverride None
76 Order allow,deny
77---- puppet-2.7.1.orig/lib/puppet/network/rest_authconfig.rb
78-+++ puppet-2.7.1/lib/puppet/network/rest_authconfig.rb
79-@@ -18,6 +18,7 @@ module Puppet
80- { :acl => "/certificate/", :method => :find, :authenticated => false },
81- { :acl => "/certificate_request", :method => [:find, :save], :authenticated => false },
82- { :acl => "/status", :method => [:find], :authenticated => true },
83-+ { :acl => "/resource", :method => [:find, :save, :search], :authenticated => true },
84- ]
85-
86- def self.main
87
88=== added file 'debian/patches/fix_logcheck'
89--- debian/patches/fix_logcheck 1970-01-01 00:00:00 +0000
90+++ debian/patches/fix_logcheck 2011-09-20 20:52:23 +0000
91@@ -0,0 +1,10 @@
92+--- a/ext/logcheck/puppet
93++++ b/ext/logcheck/puppet
94+@@ -1,6 +1,6 @@
95+ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-master\[[0-9]+\]: (Handled resources in|Resource comparison took|Searched for (host|resources|resource params and tags) in) [0-9.]+ seconds
96+ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-master\[[0-9]+\]: Starting Puppet server version [.0-9]+$
97+-^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-master\[[0-9]+\]: Compiled catalog for [._[:alnum:]-]+ in [.0-9]+ seconds$
98++^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-master\[[0-9]+\]: Compiled catalog for [._[:alnum:]-]+ in environment [._[:alnum:]-]+ in [.[:digit:]]+ seconds$
99+ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-master\[[0-9]+\]: Caught TERM; shutting down$
100+ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-master\[[0-9]+\]: Shutting down$
101+ ^\w{3} [ :0-9]{11} [._[:alnum:]-]+ puppet-agent\[[0-9]+\]: Starting Puppet client version [.0-9]+$
102
103=== modified file 'debian/patches/series'
104--- debian/patches/series 2011-07-25 01:00:37 +0000
105+++ debian/patches/series 2011-09-20 20:52:23 +0000
106@@ -1,1 +1,2 @@
107+fix_logcheck
108 debian-changes

Subscribers

People subscribed via source and target branches

to all changes: