unity-2d

Merge lp:~haggai-eran/unity-2d/rtl-multi-range-950649 into lp:unity-2d

  1. rtl-multi-range-950649
  2. Merge into trunk
Proposed by Haggai Eran
Status: Merged
Approved by: Gerry Boland
Approved revision: 972
Merged at revision: 980
Proposed branch: lp:~haggai-eran/unity-2d/rtl-multi-range-950649
Merge into: lp:unity-2d
Diff against target: 38 lines (+5/-2)
1 file modified
shell/dash/MultiRangeSelectionBar.qml (+5/-2)
To merge this branch: bzr merge lp:~haggai-eran/unity-2d/rtl-multi-range-950649
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+96731@code.launchpad.net

Commit message

[dash] Mirror the MultiRange filter in RTL locales (LP: #950649)

Description of the change

Hi,

This patch solves the incorrect rendering of the multi range filter under right-to-left locales. See bug #950649 for details and screenshots.

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Beautiful Haggai, thank you very much for your contributions!
-Gerry

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/dash/MultiRangeSelectionBar.qml'
2--- shell/dash/MultiRangeSelectionBar.qml 2011-11-25 15:44:18 +0000
3+++ shell/dash/MultiRangeSelectionBar.qml 2012-03-09 09:32:19 +0000
4@@ -16,7 +16,8 @@
5 * along with this program. If not, see <http://www.gnu.org/licenses/>.
6 */
7
8-import QtQuick 1.0
9+import QtQuick 1.1
10+import "../common/utils.js" as Utils
11
12 Item {
13 id: multiRangeSelectionBar
14@@ -26,7 +27,7 @@
15 property int leftPos: 0
16 property int rightPos: 100
17
18- x: leftPos
19+ x: !Utils.isRightToLeft() ? leftPos : parent.width - rightPos
20 width: rightPos - leftPos
21 height: childrenRect.height
22
23@@ -38,6 +39,7 @@
24 height: sourceSize.height
25 anchors.left: parent.left
26 anchors.top: parent.top
27+ mirror: Utils.isRightToLeft()
28 }
29
30 Image {
31@@ -59,6 +61,7 @@
32 height: sourceSize.height
33 anchors.top: parent.top
34 anchors.right: parent.right
35+ mirror: Utils.isRightToLeft()
36 }
37
38 }

Subscribers

People subscribed via source and target branches