Merge lp:~barry/ubuntu/natty/mgltools-viewerframework/bug-685476 into lp:ubuntu/natty/mgltools-viewerframework

Thanks for working on this. It seems that revision 12 is empty. Was there supposed to be something in there?

Actually, no ;). It's an empty commit just to link the branch to the bug (essentially equivalent to 'bzr commit --unchanged --fixes=lp:123456'). Happens if I forget to --fixes on the last substantive commit before I push.

thank you for your work there, shouldn't you use a patch system rather than changing the source directly? could you also add the patch to the debian bug? the debian bug mention it could be a python issue, what's up with that?

Setting to "Work In Progress" so it doesn't show on the sponsoring list, set it back to "Needs Review" when you reply to the questions but it would be nice to stay on sync with Debian with this one, we should at least give them a ping with the patch in the bts bug

% what-patch
patchless?

So I've been told it's bad form to add a patch system when there isn't one already, and to just patch the source directly. I'm not sure the commented out inclusion of simple-patchsys.mk counts as "having a patch system already".

I'll be happy to add the patch to the bts, and I'm happy to let the Debian maintainer decide exactly how to make the change there (and we'll pick that up on the next sync).

I was involved in the upstream issue; it's a deliberate change in semantics for Python 2.7. Assignment to __debug__ was always considered illegal, but through accident it was allowed in < 2.7 when __debug__ was used as an attribute. In 2.7, that bug was fixed.

I just have to do a test build before uploading, but tentatively approved. Thanks! BTW, you can just uncommit and use debcommit which does --fixes automatically for you.

By the way, please send the patch to Debian as you suggested. You can use the submittodebian tool in ubuntu-dev-tools or the guidelines here for tagging: https://wiki.ubuntu.com/Debian/Usertagging
Thanks!