Merge lp:~aacid/ubuntu-ui-toolkit/anchors_cant_be_null into lp:ubuntu-ui-toolkit/staging

Proposed by Albert Astals Cid
Status: Merged
Approved by: Zsombor Egri
Approved revision: 2181
Merged at revision: 2181
Proposed branch: lp:~aacid/ubuntu-ui-toolkit/anchors_cant_be_null
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 14 lines (+2/-2)
1 file modified
src/imports/Components/ListItems/1.3/ThinDivider.qml (+2/-2)
To merge this branch: bzr merge lp:~aacid/ubuntu-ui-toolkit/anchors_cant_be_null
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+318450@code.launchpad.net

Commit message

ThinDivider: Anchors can't be null, set to undefined

Description of the change

Fix warning we get sometimes in unity8
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/ListItems/1.3/ThinDivider.qml:51:16: Unable to assign null to QQuickAnchorLine

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

Fair point on null->undefined! Thanks for the fix!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Components/ListItems/1.3/ThinDivider.qml'
2--- src/imports/Components/ListItems/1.3/ThinDivider.qml 2015-07-05 21:04:55 +0000
3+++ src/imports/Components/ListItems/1.3/ThinDivider.qml 2017-02-28 10:16:03 +0000
4@@ -47,8 +47,8 @@
5 */
6 Rectangle {
7 anchors {
8- left: (parent) ? parent.left : null
9- right: (parent) ? parent.right : null
10+ left: (parent) ? parent.left : undefined
11+ right: (parent) ? parent.right : undefined
12 }
13 height: (visible) ? units.dp(2) : 0
14 // a private property to catch theme background color change

Subscribers

People subscribed via source and target branches