rechecks are silently ignored if the comment is against an older version

Bug #1323394 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zuul
Triaged
Wishlist
Unassigned

Bug Description

This may sound like correct behaviour, but actually its fairly easy to end up on an older versions 'add comment' form, and the complete lack of feedback means that zuul appears to be flaky, rather than being 'correct'.

In a discussion with fungi on IRC we couldn't come up with any reason not to just use the latest patchset for recheck actions, for ease of use:

07:08 < fungi> lifeless: probably worth a wishlist bug for zuul to translate the patchset number in the comment
               via a lookup to find out what the latest patchset for that change is, rather than simply
               ignoring it outright
07:09 < fungi> lifeless: there may be unforseen interactions resulting from that, but at the moment none come
               to mind

So to whit, one wishlist bug.

Revision history for this message
Jeremy Stanley (fungi) wrote :

Given the genericity of the comment handler, this would likely need to be a configurable toggle so you could set specific comment triggers to assume latest patchset or something along those lines.

Changed in zuul:
status: New → Triaged
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.