enqueuing loop on comment-added event trigger
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zuul |
New
|
Undecided
|
Unassigned |
Bug Description
Zuul reenqueued a patch in the check queue every time Jenkins added a verified comment.
The change was 2 months old when it was -2'd which started the loop. The loop seems to have stopped when the patch was abandoned: https:/
2014-02-26 00:11:26,961 DEBUG zuul.Independen
2014-02-26 00:11:26,961 INFO zuul.Independen
2014-02-26 00:11:26,961 DEBUG zuul.reporter.
2014-02-26 00:11:27,543 INFO zuul.Gerrit: Updating information for 49755,1
2014-02-26 00:11:27,761 DEBUG zuul.Independen
2014-02-26 00:11:27,782 DEBUG zuul.Gerrit: Change <Change 0x7f4a17198790 49755,1> status: NEW
2014-02-26 00:11:27,925 DEBUG zuul.Scheduler: Adding trigger event: <TriggerEvent comment-added openstack/cinder stable/grizzly 49755,1 VRIF:1>
2014-02-26 00:11:27,925 DEBUG zuul.Scheduler: Done adding trigger event: <TriggerEvent comment-added openstack/cinder stable/grizzly 49755,1 VRIF:1>
2014-02-26 00:11:27,925 DEBUG zuul.Scheduler: Processing trigger event <TriggerEvent comment-added openstack/cinder stable/grizzly 49755,1 VRIF:1>
2014-02-26 00:11:27,926 INFO zuul.Gerrit: Updating information for 49755,1
2014-02-26 00:11:28,017 DEBUG zuul.Gerrit: Change <Change 0x7f4a14f0fad0 49755,1> status: NEW
2014-02-26 00:11:28,064 INFO zuul.Scheduler: Adding openstack/cinder, <Change 0x7f4a14f0fad0 49755,1> to <Pipeline check>
2014-02-26 00:11:28,064 DEBUG zuul.Independen
Also having more logs about what gerrit information zuul uses for its decisions would be helpful, such as age of the change, existing votes on the change and other information of this nature.