zuul should depends on statsd 2 or later not old statsd 1.0.0

Bug #1169599 reported by Antoine "hashar" Musso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zuul
Fix Committed
Medium
Antoine "hashar" Musso

Bug Description

Zuul has a dependencies to the statsd pypi module which is pinned to 1.0.0. That modules has a 2.0.1 version. We have to port Zuul to whatever new API upstream authors came with.

Revision history for this message
Antoine "hashar" Musso (hashar) wrote :

I am going to hack Zuul.

Changed in zuul:
assignee: nobody → Antoine "hashar" Musso (hashar)
Revision history for this message
Antoine "hashar" Musso (hashar) wrote :

I have bumped the dependency to 2.0.1 to trigger a discussion in Gerrit: https://review.openstack.org/#/c/27008/ . Will follow up there.

Changed in zuul:
status: New → In Progress
Revision history for this message
Antoine "hashar" Musso (hashar) wrote :

James added statsd tests in https://review.openstack.org/#/c/27306/1

The requirement will be made statsd>=1.0.0,<3.0 to prevent unexpected upgrades.

Jeremy Stanley (fungi)
Changed in zuul:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zuul (master)

Reviewed: https://review.openstack.org/27008
Committed: http://github.com/openstack-infra/zuul/commit/5925743f36ee9d13b847127e236eb5ffea1ed89e
Submitter: Jenkins
Branch: master

commit 5925743f36ee9d13b847127e236eb5ffea1ed89e
Author: Antoine Musso <email address hidden>
Date: Tue Apr 16 17:35:52 2013 +0200

    soften statsd version requirement to allow v2

    We used to pin statsd to version 1.0.0. James E. Blair has written a
    few tests that now let us allow the current v2.0.1 version. To prevent
    unexpected upgrades, we disallow v3.0.0.

    Zuul scheduler only do very simple statsd operations. Testing with
    statsd 2.0.1:

    I have set up a basic listener:

     listener$ netcat -l 127.0.0.1 -p 666 --udp

    Then wrote the python script:

      import extras
      statsd = extras.try_import('statsd.statsd')

      statsd.incr('zuul.counter')
      statsd.timing('zuul.timer', 1234)
      statsd.timing('zuul.timer', 1)
      statsd.gaug:('zuul.gauge', 1234)

    Running it as:
      STATSD_HOST='127.0.0.1' STATSD_PORT=666 python statsd-test.py

    The listener gets:

      zuul.counter:1|czuul.timer:1234|mszuul.timer:1|mszuul.gauge:1234|g

    Sounds legit enough.

    Fix bug #1169599 'Zuul should depends on statsd 2 or later'

    Change-Id: I41b797d606d55eeda300e673b05c2ae4442ce029

Changed in zuul:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.