Zun

Check API version on 'restart_policy'

Bug #1780279 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zun
Triaged
High
Unassigned

Bug Description

Below is @jtopjian's feedback from Gophercloud. As mentioned by @jtopjian, we should check API version on the 'restart_policy' property.

=======================================
@hongbin From reading the upstream Zun patches, if Gophercloud supported microversions, I don't think that would have prevented this issue.

The upstream patch you identified as the cause of the test failures is here: https://review.openstack.org/#/c/571398/

I might be incorrect, but I don't see anything in that code which is checking for a microversion before performing an action. As an example, this is how Nova handles different behavior depending on the microversion:

https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/migrations.py#L116-L143

According to the microversion spec, all prior behavior should still be successful and not require a microversion increase to the client. It's only after the client opts-in to a microversion that new features, such as restart_policy should be seen.
======================================

hongbin (hongbin034)
Changed in zun:
importance: Undecided → High
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.