Convert type of 'command' from string to list

[hongbin]

Zun is currently using a string representation of 'command', but Docker is returning 'Cmd' in string representation. This requires a conversion of commands between list and string, which is complicated and error-prone (it might causes bugs like https://review.openstack.org/#/c/551795/).

It is better to switch from string to list. In particular, this includes:

* DB model (zun/db/sqlalchemy/models.py): store 'command' as list instead of string
* API (zun/api/validation/parameter_types.py): convert the 'command' parameter from string to list (this requires a micro-version bump. see here: https://docs.openstack.org/zun/latest/contributor/api-microversion.html).
* Driver (zun/container/docker/driver.py): On creating container, pass the list representation of 'command' to docker (docker supports both list and string 'command' in container_create https://docker-py.readthedocs.io/en/stable/api.html#docker.api.container.ContainerApiMixin.create_container).

[Deepak Mourya (mourya007)]

Hi, for microversion bump here you mean adding something like @base.Controller.api_version("1.2", "1.3") to determine api modification .

[hongbin (hongbin034)]

Yes and no. First, this is a change of method's behavior, so make sure doing this:

  https://docs.openstack.org/zun/latest/contributor/api-microversion.html#changing-a-method-s-behavior

In addition, there are other necessary changes:

  https://docs.openstack.org/zun/latest/contributor/api-microversion.html#other-necessary-changes

[hongbin (hongbin034)]

Unassigned due to no activity since 2018-03-20

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/575709

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/575709
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=b03fbe6dfddea496bc156ee45c44f972d4ebd580
Submitter: Zuul
Branch: master

commit b03fbe6dfddea496bc156ee45c44f972d4ebd580
Author: rajat29 <email address hidden>
Date: Fri Jun 15 14:50:48 2018 +0530

    Convert type of 'command' from string to list

    Zun is currently using a string representation of 'command',
    but Docker is returning 'Cmd' in string representation. This
    requires a conversion of commands between list and string,
    which is complicated and error-prone (it might causes bugs like
    https://review.openstack.org/#/c/551795/).
    It is better to switch from string to list

    Co-Authored-By: Hongbin Lu <email address hidden>

    Change-Id: Ie0df504a67cc20907d35e3513fd80d3f6be687fd
    Closes-Bug: #1755019

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/580253

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/580253
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=aafdd20617e882620f956a2c7cac3c67343cf690
Submitter: Zuul
Branch: master

commit aafdd20617e882620f956a2c7cac3c67343cf690
Author: Hongbin Lu <email address hidden>
Date: Thu Jul 5 02:43:02 2018 +0000

    capsule: convert 'command' from string to list

    Change-Id: I644f7488190e11205ce958d8b79c9541a7ea10ec
    Related-Bug: #1755019

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/zun 2.0.0 release.