Zun

Variable name (db_containers) is ambiguous

Bug #1743353 reported by Ji.Wei
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zun
Fix Released
Low
hongbin

Bug Description

When reading the code, I found the variable name here is ambiguous:

https://github.com/openstack/zun/blob/master/zun/container/docker/driver.py#L327

The variable name is db_containers, which actually records the information of the docker container, not the information in the zun database.

Ji.Wei (jiwei)
Changed in zun:
assignee: nobody → Ji.Wei (jiwei)
Ji.Wei (jiwei)
description: updated
Revision history for this message
hongbin (hongbin034) wrote :

Feel free to propose a better name if you have any.

Changed in zun:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zun (master)

Fix proposed to branch: master
Review: https://review.openstack.org/545641

Changed in zun:
assignee: Ji.Wei (jiwei) → hongbin (hongbin034)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zun (master)

Reviewed: https://review.openstack.org/545641
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=3a94c26bd9ba1efbbf381d6c47555deded612feb
Submitter: Zuul
Branch: master

commit 3a94c26bd9ba1efbbf381d6c47555deded612feb
Author: Hongbin Lu <email address hidden>
Date: Sat Feb 17 23:11:01 2018 +0000

    Rename variable 'db_containers'

    The variable 'db_containers' or 'db_container' is ambiguous.
    This patch rename the variable to make it clear.

    Change-Id: I92eff97f6edd441b7fab89de979bafb2aa70939d
    Closes-Bug: #1743353

Changed in zun:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/zun 2.0.0

This issue was fixed in the openstack/zun 2.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.