Zun

Validate security groups at zun-api

Bug #1698458 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zun
Fix Released
High
feng.shengqin@zte.com.cn

Bug Description

Currently, we validates security groups at container driver (in particular, at _get_security_group_ids [1]). If user submits wrong security groups, the request will still be accepted and the container will go into "Error" state.

This ticket proposes to improve the user experience by validating the security group earlier at zun-api and reject the request if invalid. Therefore, user will know earlier that his/her provided security groups are invalid. The validation code could goes into the "post" method [2].

[1] https://github.com/openstack/zun/blob/master/zun/container/docker/driver.py#L559
[2] https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/containers.py#L203

See original description
hongbin (hongbin034)
description: updated
Changed in zun:
importance: Undecided → High
status: New → Triaged
feng.shengqin@zte.com.cn (feng-shengqin)
Changed in zun:
assignee: nobody → feng.shengqin@zte.com.cn (feng-shengqin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zun (master)

Fix proposed to branch: master
Review: https://review.openstack.org/475111

Changed in zun:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on zun (master)

Change abandoned by feng.shengqin (<email address hidden>) on branch: master
Review: https://review.openstack.org/475111

Revision history for this message
hongbin (hongbin034) wrote :

I believe this is already implemented. I am going to close this bug.

Changed in zun:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.