Stop sandbox if container is not running

[hongbin]

See @Shubham's comment in review https://review.openstack.org/#/c/396896/ :

  If we are at this line then we can safely assume that sandbox container for this container was started successfully. But here container creation has failed but respective sandbox container will still be in running state. Should we stop corresponding sandbox container?
  If we do not do that then we will have sandbox containers piled up for each failed instance of container create .

Right now, the sandbox container is always running when the normal container is created. An improvement is to stop the sandbox container when the normal container is stopped. Consider this as an optional improvement. We don't need this right away.

[Pradeep Kumar Singh (pradeep-singh-u)]

I am working on this.

[hongbin (hongbin034)]

NOTE: fixing this bug is not trivial. It requires an atomic operation between container and sandbox (i.e. stop container and sandbox at the same time). It also needs to handle several corner cases (i.e. stop the sandbox if the container failed to create. I am ok to leave this bug as "won't fix" if the fix is too complicated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/407850

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/407850
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=7ea0d85bf4b278e93d85d57aa84fc758b47eaf10
Submitter: Jenkins
Branch: master

commit 7ea0d85bf4b278e93d85d57aa84fc758b47eaf10
Author: Pradeep Kumar Singh <email address hidden>
Date: Wed Dec 7 05:04:09 2016 +0000

    Delete sandbox when container create fails

    This patch deletes the sandbox when container create fails.

    Partially-Closes-Bug: #1644570
    Change-Id: I1d0bc39422109b20f69a21ce0d20799cecb6c2c9