URIs for files should be valid with one slash
Bug #921258 reported by
Rodolfo Ochoa
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zorba |
Fix Released
|
Medium
|
Rodolfo Ochoa | ||
Bug Description
URIs for files should be valid with only one slash.
This examples should be valid:
file:///C:/file.xq
file:/C:/file.xq
Related branches
lp:~zorba-coders/zorba/bug925816
- Rodolfo Ochoa: Approve
- Cezar Andrei: Approve
- Matthias Brantner: Pending requested
-
Diff: 38 lines (+18/-2)1 file modifiedsrc/zorbatypes/URI.cpp (+18/-2)
Revision history for this message
| Chris Hillery (ceejatec) wrote | #1 |
| Changed in zorba: | |
| assignee: | nobody → Rodolfo Ochoa (rodolfo-ochoa) |
| importance: | Undecided → Medium |
| Changed in zorba: | |
| status: | New → Fix Committed |
| Changed in zorba: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Context: this is for interoperability with Oxygen and other Java environments via XQJ. Java's URI classes still conform to RFC 2396, which allows skipping the authority section of the URI entirely, including the "//". RFC 2396 has been obsoleted by RFC 3986, which does not allow this, and which is what Zorba implements. However, unfortunately, Java isn't likely to change anytime soon.
We could fix this in two places: Either we could update our URI code to allow this case directly, or we could add a layer inside XQJ which "translates" these URIs. There are downsides either way. If we can do it in our URI code without causing other problems, that's probably the better approach, but I don't know if it's possible (presumably the RFC was changed for some good reason, which we may re-discover if we attempt to make the change at that low a level).