Debugger: crash when breakpoint remove
Bug #898575 reported by
Gabriel Petrovay
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zorba |
Fix Released
|
High
|
Gabriel Petrovay | ||
Bug Description
query mm.xq:
1 | for $x in 1 to 3
2 | return
3 | $x
(xqdb) bs -f q -l 3
(xqdb) br -d 0
!!!CRASH!!!
Related branches
lp:~zorba-coders/zorba/debugger_client
- David Graf (community): Approve
- Gabriel Petrovay (community): Approve
- Juan Zacarias: Pending requested
-
Diff: 6749 lines (+3407/-2155)47 files modifiedCMakeConfiguration.txt (+7/-4)
bin/CMakeLists.txt (+21/-18)
bin/debug_client/debug_command.cpp (+0/-99)
bin/debug_client/event_handler_init.cpp.in (+0/-41)
bin/debug_client/lock_free_queue.cpp (+0/-16)
bin/debug_client/message-handler.xq (+0/-165)
bin/debugger/command.h (+164/-211)
bin/debugger/command_arg.h (+237/-0)
bin/debugger/command_line_handler.cpp (+350/-203)
bin/debugger/command_line_handler.h (+111/-58)
bin/debugger/command_prompt.cpp (+246/-0)
bin/debugger/command_prompt.h (+60/-0)
bin/debugger/config.h.cmake (+24/-0)
bin/debugger/event_handler.cpp (+82/-76)
bin/debugger/event_handler.h (+25/-12)
bin/debugger/lock_free_queue.h (+10/-2)
bin/debugger/main.cpp (+290/-14)
bin/debugger/tuple.h (+6/-0)
bin/zorbacmd.cpp (+7/-9)
cmake_modules/FindLibedit.cmake (+46/-0)
include/zorba/config.h.cmake (+8/-8)
include/zorba/debugger_client.h (+9/-1)
modules/com/zorba-xquery/www/modules/CMakeLists.txt (+7/-0)
modules/com/zorba-xquery/www/modules/debugger/dbgp-message-handler.xq (+277/-0)
src/compiler/expression/expr.cpp (+0/-1)
src/compiler/translator/translator.cpp (+5/-7)
src/debugger/debugger_client.cpp (+0/-2)
src/debugger/debugger_clientimpl.cpp (+545/-458)
src/debugger/debugger_clientimpl.h (+16/-9)
src/debugger/debugger_common.h (+3/-10)
src/debugger/debugger_commons.cpp (+122/-24)
src/debugger/debugger_commons.h (+11/-15)
src/debugger/debugger_communicator.cpp (+3/-3)
src/debugger/debugger_communicator.h (+4/-4)
src/debugger/debugger_protocol.cpp (+28/-16)
src/debugger/debugger_runtime.cpp (+308/-87)
src/debugger/debugger_runtime.h (+29/-12)
src/debugger/debugger_server.cpp (+229/-85)
src/debugger/debugger_server.h (+15/-1)
src/debugger/socket_streambuf.cpp (+68/-55)
src/debugger/socket_streambuf.h (+20/-9)
src/unit_tests/CMakeLists.txt (+0/-6)
src/unit_tests/test_debugger_protocol.cpp (+0/-414)
test/rbkt/ExpQueryResults/zorba/debugger/dmh/break_response.xml.res (+1/-0)
test/rbkt/ExpQueryResults/zorba/debugger/dmh/break_response_no_info.xml.res (+1/-0)
test/rbkt/Queries/zorba/debugger/dmh/break_response.xq (+5/-0)
test/rbkt/Queries/zorba/debugger/dmh/break_response_no_info.xq (+7/-0)
| summary: |
- Debugger: Crash when breakpoint remove + Debugger: crash when breakpoint remove |
Revision history for this message
| Gabriel Petrovay (gabipetrovay) wrote | #1 |
| Changed in zorba: | |
| status: | New → In Progress |
| status: | In Progress → Fix Committed |
| description: | updated |
| Changed in zorba: | |
| milestone: | none → 2.2 |
| Changed in zorba: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The problem was with unprotected call to:
theRuntime-
which throws an exception if the breakpoint id is wrong.
Now surrounded with try catch and properly displaying the information in the client.