test/unit/string_test crashes in Debug on Windows

[Daniel Turcanu]

The Unit Test string_test is crashing on Windows in debug mode.
I am testing on no-unicode branch, for both unicode and ascii modes. It crashes for both modes.
My investigation leads to src/util/utf8_util_base.h: 379, when oi_ is incremented beyond the end of string, dereferencing the last \0 fires an assert in Windows.
I think you should check for end() before dereferencing the iterator.

[Paul J. Lucas (paul-lucas)]

Unfortunately, I don't have access to "end()" to compare it to. The only thing I can think of is to do:

if ( *oi ) while ( !is_start_byte( *++oi_ ) ) ;

Can you try that out and let me know? Thanks.

[Matthias Brantner (matthias-brantner)]

No that doesn't solve the problem. Before incrementing the iterator, it still points to the "o" of "hello" which is OK. Only after incrementing it on the "o", the iterator points to the end and Windows doesn't allow for calling the *operator on it anymore.