Zorba

InvalidTimezoneException should contain the invalid timezone

Bug #866973 reported by Paul J. Lucas
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Zorba
Fix Released
Medium
Paul J. Lucas
Zorba 2.8 "Hermes"

Bug Description

The InvalidTimezoneException class is currently empty. It should be modified to contain the timezone value that is invalid and provide a "getter" method to retrieve it. Also, since it is derived from std::exception, it should override the what() method.

Once this is done, the invalid timezone value can be retrieved and included in error messages when the exception is rethrown as an XQueryException.

Tags: core-runtime

Related branches

lp:~paul-lucas/zorba/bug-866973
Sorin Marian Nasoi: Approve
Nicolae Brinza: Approve
Paul J. Lucas: Approve
Diff: 170 lines (+26/-19)
7 files modified
src/diagnostics/diagnostic_en.xml (+1/-1)
src/diagnostics/pregenerated/dict_en.cpp (+1/-1)
src/runtime/core/arithmetic_impl.cpp (+6/-6)
src/runtime/durations_dates_times/DurationsDatesTimesImpl.cpp (+4/-4)
src/store/naive/atomic_items.cpp (+4/-4)
src/zorbatypes/datetime.h (+7/-0)
src/zorbatypes/datetime/datetimetype.cpp (+3/-3)
Revision history for this message
Markos Zaharioudakis (markos-za) wrote :

Sorin, I think this is in code you implemented. So, please take a look or re-assign it to whoever "owns" this code.

Dana Florescu (dflorescu)
Changed in zorba:
milestone: none → 2.7
Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) wrote :

Assigning to Nicolai because he owns the datetime code.

Changed in zorba:
assignee: Sorin Marian Nasoi (sorin.marian.nasoi) → Nicolae Brinza (nbrinza)
Matthias Brantner (matthias-brantner)
Changed in zorba:
milestone: 2.7 → 2.8
Revision history for this message
Chris Hillery (ceejatec) wrote :

Paul, you have a pretty clear idea of what should change here; please take a crack at implementing it. If there are datetime-specific questions you have, please involve Nicolai, but don't ask him to do the work as he is over-committed for 2.8.

Changed in zorba:
assignee: Nicolae Brinza (nbrinza) → Paul J. Lucas (paul-lucas)
Revision history for this message
Chris Hillery (ceejatec) wrote :

Is this indeed fixed? If so, please mark it 'Fix Committed'.

Paul J. Lucas (paul-lucas)
Changed in zorba:
status: New → Fix Committed
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.